747308 - getInstalledAddons should filter the callback

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Remus Pop (:RemusPop)]

function getInstalledAddons(callbackFilter) from addons module does not filter the results from the callback(simply said the callback cannot work as a filter). So we should only push data to the table if the callback is true.

Comment 1

[Remus Pop (:RemusPop)]

Attachment: proposed v1 (all branches)

The result from the callback will be stored in a local variable. Data will be added to the array if the variable contains something (not null, not undefined, not 0).

Comment 2

[u279076]

Any bugs for Shared Modules go in the Mozilla QA :: Mozmill Shared Modules component.

Comment 3

[Remus Pop (:RemusPop)]

Sorry, I got carried away by bug 714802 and others.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #2)
> Any bugs for Shared Modules go in the Mozilla QA :: Mozmill Shared Modules
> component.

No, it does not. Please see my message on the public mailing list. Two days ago all of the shared module bugs have been carried over to tests and the component will be abandoned early next week.

Comment 5

[u279076]

Can you please link me to the post? I don't understand why we want to make things more ambiguous.

Comment 6

[u279076]

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #5)
> Can you please link me to the post? I don't understand why we want to make
> things more ambiguous.

Henrik pointed me to the post on IRC, sharing here for historical context:
http://groups.google.com/group/mozilla.dev.automation/browse_thread/thread/cae651d706e51b3e#

Going forward, please use the [mozmill-shared-module] whiteboard tag.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #6)
> Going forward, please use the [mozmill-shared-module] whiteboard tag.

This is 'lib' now as you can see in all the other bugs about modules under the lib folder.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 616949 [details] [diff] [review]
proposed v1 (all branches)

>   AddonManager.getAllAddons(function (aAddons) {
>     if (callbackFilter == undefined) {
>       addonInfo = aAddons;
>     } else {

While you are on it, can you please push the else to a new line? Otherwise it looks good.

Comment 9

[Remus Pop (:RemusPop)]

Attachment: patch v2 (all branches)

Else has been moved to a new line.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 617807 [details] [diff] [review]
patch v2 (all branches)

Looks good. Thanks Remus.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Given that this feature blocks a failure I have landed the patch across branches:

http://hg.mozilla.org/qa/mozmill-tests/rev/ab1cb77d7d31 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/20895ce40855 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/01195f17c569 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/5393c9b4fa39 (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/2909e4a74f7c (esr10)

Comment 12

[u279076]

(In reply to Henrik Skupin (:whimboo) from comment #7)
> (In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #6)
> > Going forward, please use the [mozmill-shared-module] whiteboard tag.
> 
> This is 'lib' now as you can see in all the other bugs about modules under
> the lib folder.

I would much prefer that you use [mozmill-shared-module] so that it is in line with the nomenclature of all our other mozmill* whiteboard tags.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's not a debate I want to have on a bug. Feel free to start a discussion on the newsgroup if still necessary but in short, the other whiteboard tags have a mozmill prefix because of their usage outside of the mozmill-tests component. 'lib' related bugs will always stay inside. Also I wouldn't use 'shared-module' anymore because the folder isn't named that way anymore and will only cause confusion.