|
3.76 KB,
patch
|
Callek
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-esr10+
|
Details | Diff | Splinter Review |
Thunderbird comm-central builds are failing here: ------------------ configuring in ctypes/libffi running /bin/sh /builds/slave/tb-comm-cen-lnx/build/mozilla/js/src/ctypes/libffi/configure --disable-shared --enable-static --disable-raw-api --with-pic --cache-file=/builds/slave/tb-comm-cen-lnx/build/objdir-tb/mozilla/js/src/ctypes/libffi/config.cache --srcdir=/builds/slave/tb-comm-cen-lnx/build/mozilla/js/src/ctypes/libffi configure: creating cache /builds/slave/tb-comm-cen-lnx/build/objdir-tb/mozilla/js/src/ctypes/libffi/config.cache checking build system type... i686-pc-linux-gnu checking host system type... i686-pc-linux-gnu checking target system type... i686-pc-linux-gnu checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking for gcc... gcc checking whether the C compiler works... no configure: error: in `/builds/slave/tb-comm-cen-lnx/build/objdir-tb/mozilla/js/src/ctypes/libffi': configure: error: C compiler cannot create executables See `config.log' for more details. configure: error: /builds/slave/tb-comm-cen-lnx/build/mozilla/js/src/ctypes/libffi/configure failed for ctypes/libffi configure: error: /builds/slave/tb-comm-cen-lnx/build/mozilla/js/src/configure failed for js/src configure: error: /builds/slave/tb-comm-cen-lnx/build/mozilla/configure failed for mozilla *** Fix above errors and then restart with "make -f client.mk build" make[2]: *** [configure] Error 1 make[2]: Leaving directory `/builds/slave/tb-comm-cen-lnx/build' make[1]: *** [objdir-tb/Makefile] Error 2 make[1]: Leaving directory `/builds/slave/tb-comm-cen-lnx/build' make: *** [build] Error 2 program finished with exit code 2 elapsedTime=441.892198 ------------- The config log (/builds/slave/tb-comm-cen-lnx/build/objdir-tb/mozilla/js/src/ctypes/libffi/config.log) shows that we are picking up the wrong version of gcc: ----------- configure:3514: gcc --version >&5 gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52) -----------
|
(Assignee) | |
Comment 1•5 years ago
|
||
Some digging reveals two issues. The main one being that libffi doesn't seem to pick up the gcc that's specified in mozconfig. It picks up the system default - just as comment 0 says. I have raised bug 748138 for that. The secondary issue is that we're specifying export CFLAGS="-gdwarf-2" export CXXFLAGS="-gdwarf-2" This seems to be messing up the default gcc 4.1.1, iirc that had a different symbol default (or was it further back than that). Anyway, removing these lines and the --enable-debug-symbols ones fixes the issue with the compilation failing. This brings the mozconfigs more into sync with Firefox (who removed those options a while ago as they are default), so I think we are safe to do that here.
|
|
(Assignee) | |
Comment 2•5 years ago
|
||
Created attachment 617656 [details] [diff] [review] The fix
|
||
Updated•5 years ago
|
||
|
|
(Assignee) | |
Comment 3•5 years ago
|
||
Checked in: https://hg.mozilla.org/comm-central/rev/c671975adf5f
|
|
(Assignee) | |
Comment 4•5 years ago
|
||
Comment on attachment 617656 [details] [diff] [review] The fix [Triage Comment] We'll want this on aurora as well for the build automation changes.
|
|
(Assignee) | |
Comment 5•5 years ago
|
||
Checked in: http://hg.mozilla.org/releases/comm-aurora/rev/6bf9e01901a6
|
|
(Assignee) | |
Comment 6•5 years ago
|
||
Comment on attachment 617656 [details] [diff] [review] The fix [Triage Comment] Need to sync this to ESR so that we can run the new build systems there as well.
|
|
(Assignee) | |
Comment 7•5 years ago
|
||
Checked in: https://hg.mozilla.org/releases/comm-esr10/rev/4baededdfac0
Description
•