Add-ons restart tests are broken due to broken behavior in startUserShutdown

VERIFIED FIXED

Status

Mozilla QA
Mozmill Tests
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: whimboo, Assigned: RemusPop)

Tracking

unspecified
Bug Flags:
in-litmus +

Firefox Tracking Flags

(firefox13 fixed, firefox14 fixed, firefox15 fixed, firefox16 fixed, firefox-esr10 fixed)

Details

(Whiteboard: [mozmill-test-failure][needs-mozmill-1.5.13])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
With the automatic port selection of jsbridge we detected that startUserShutdown is broken. We don't intent to fix it for Mozmill 1.5.x so those tests have to be skipped for now until 2.0 is available.

Affected tests:
(Reporter)

Comment 1

5 years ago
restartTests/testAddons_changeTheme
restartTests/testAddons_enableDisableExtension
restartTests/testAddons_uninstallExtension

But instead of disabling those tests we could simply use a Mozmill initiated restart.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
(Reporter)

Comment 2

5 years ago
Created attachment 616993 [details] [diff] [review]
Patch v1 (Remove startUserShutdown)
Attachment #616993 - Flags: review?(anthony.s.hughes)
Comment on attachment 616993 [details] [diff] [review]
Patch v1 (Remove startUserShutdown)

Looks good to me.
Attachment #616993 - Flags: review?(anthony.s.hughes) → review+
(Reporter)

Comment 4

5 years ago
Landed across branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/0b7b34d752fe (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/1ef7e7d066dd (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/bce77c223039 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/f71fcc3363c9 (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/fb4c6a70416b (esr10)
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
It is fixed now in mozmill 1.5.13 so I'll test before backing out the patch.
Assignee: hskupin → remus.pop
Status: RESOLVED → REOPENED
status-firefox-esr10: --- → affected
status-firefox13: --- → affected
status-firefox14: --- → affected
status-firefox15: --- → affected
status-firefox16: --- → affected
Resolution: FIXED → ---
(Reporter)

Updated

5 years ago
Whiteboard: [mozmill-test-failure][needs-mozmill-2.0] → [mozmill-test-failure][needs-mozmill-1.5.13]
(Assignee)

Comment 6

5 years ago
Results for Mac:
http://mozmill-crowd.blargon7.com/#/functional/report/8bf3fa70d3d9a46d3e7617383b11b9a4

Linux:
http://mozmill-crowd.blargon7.com/#/functional/report/8bf3fa70d3d9a46d3e7617383b11d5fd

Windows XP does not report yet; there might be some problem.
(Assignee)

Comment 7

5 years ago
Created attachment 634028 [details] [diff] [review]
patch v1 (all branches)

Restores startUserShutdown in tests that used it. Applies on all branches, including esr10.
Attachment #634028 - Flags: review?(hskupin)
(Reporter)

Comment 8

5 years ago
Comment on attachment 634028 [details] [diff] [review]
patch v1 (all branches)

Usually we do not want to have new patches but backout the ones we have already landed. So I'm going to mark this as obsolete and backout the already landed one.
Attachment #634028 - Attachment is obsolete: true
Attachment #634028 - Flags: review?(hskupin)
(Reporter)

Comment 9

5 years ago
http://hg.mozilla.org/qa/mozmill-tests/rev/b7ccc50843bb (default)
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
status-firefox16: affected → fixed
Resolution: --- → FIXED
Whiteboard: [mozmill-test-failure][needs-mozmill-1.5.13] → [mozmill-test-failure][mozmill-test-skipped][needs-mozmill-1.5.13]
(Reporter)

Comment 10

5 years ago
(In reply to Henrik Skupin (:whimboo) from comment #9)
> http://hg.mozilla.org/qa/mozmill-tests/rev/b7ccc50843bb (default)

I accidentally checked this into aurora and not default. But given that no failures have been reported we can land it on all other branches:

http://hg.mozilla.org/qa/mozmill-tests/rev/0da43de2c0b6 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/11baf0de21df (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/d118606a4459 (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/b5475fe282ea (esr10)
status-firefox-esr10: affected → fixed
status-firefox13: affected → fixed
status-firefox14: affected → fixed
status-firefox15: affected → fixed
Flags: in-litmus?(remus.pop)
Whiteboard: [mozmill-test-failure][mozmill-test-skipped][needs-mozmill-1.5.13] → [mozmill-test-failure][needs-mozmill-1.5.13]
(Assignee)

Comment 11

5 years ago
Edited/updated/enabled:

1. testAddons_changeTheme
2. testAddons_enableDisableExtension
3. testAddons_uninstallExtension

esr10
1. 40731
2. 40724
3. 40727

release
1. 55626
2. 55619
3. 55622

beta
1. 63980
2. 63973
3. 63976

aurora
1. 15633
2. 15626
3. 15438
Status: RESOLVED → VERIFIED
Flags: in-litmus?(remus.pop) → in-litmus+
You need to log in before you can comment on or make changes to this bug.