747453 - Move and slight refactor @vouch_required

Status: VERIFIED INVALID

(Participation Infrastructure :: Phonebook, defect)

Description

[James Socol [:jsocol, :james]]

We should do two things differently with the @vouch_required decorator:

1) Put it in something like phonebook.decorators. It doesn't need to live in phonebook.views.
2) The unvouched case should 'raise PermissionDenied', not return an HttpResponse subclass.

That'll let the 403 handler catch it.

Alternatively, we could subclass PermissionDenied:

    class VouchRequired(PermissionDenied):
        """A witty description."""

Then in a 403 handler view, do something slightly different for "you need a voucher" vs "you don't have permission to do that".

Comment 1

[Giorgos Logiotatidis [:giorgos]]

In bug 846039 we removed all related code. Marking this one  invalid.

Comment 2

[Matt Brandt [:mbrandt]]

Resolving to verified invalid per comment 1.