Closed Bug 747460 Opened 14 years ago Closed 14 years ago

consolidate windows peptest config files

Categories

(Release Engineering :: General, defect, P5)

All
Windows XP
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozilla, Assigned: mozilla)

Details

(Whiteboard: [mozharness])

Attachments

(3 files)

In peptest, we currently have prod_config.py (linux+mac), w764_config.py, win7_config.py, and xp_config.py. I had to separate win7_config.py and xp_config.py in staging due to a differing virtualenv. However, this difference didn't exist in production, so I ended up making the win7_config.py the same. w764_config.py came about because of the windows logic in mozilla-tests/config.py was breaking on w764: http://hg.mozilla.org/build/buildbot-configs/file/2bdb451619d9/mozilla-tests/config.py#l1228 Now we have 3 config files that are exactly the same, with logic on how to call them separately. We should consolidate the config files to one windows_config.py and call that for all 3 platforms.
Rail: these 3 reviews aren't urgent (next week is fine), but they're pretty simple. This patch copies xp_config.py to windows_config.py and can land at any point.
Attachment #617087 - Flags: review?(rail)
This points windows peptest runs at windows_config.py. This patch needs to land after attachment 617087 [details] [diff] [review], and will need a reconfig.
Attachment #617089 - Flags: review?(rail)
Comment on attachment 617087 [details] [diff] [review] [mozharness] copy xp_config.py to windows_config.py The easiest patch I've ever seen!
Attachment #617087 - Flags: review?(rail) → review+
Attachment #617089 - Flags: review?(rail) → review+
This patch removes the extraneous xp,win7,w764 config files after buildbot is pointing at the new windows_config.py file. This patch can land at any point after the reconfig for attachment 617089 [details] [diff] [review].
Attachment #617090 - Flags: review?(rail)
Attachment #617090 - Flags: review?(rail) → review+
Comment on attachment 617087 [details] [diff] [review] [mozharness] copy xp_config.py to windows_config.py http://hg.mozilla.org/build/mozharness/rev/69ef1c522d9f
Attachment #617087 - Flags: checked-in+
Attachment #617089 - Flags: checked-in+
Attachment #617090 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Landed to production yesterday.
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: