747469 - GCC 4.6 warning: nsHTMLDocument.cpp:2308:49: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

{
content/html/document/src/nsHTMLDocument.cpp: In member function ‘virtual nsresult nsHTMLDocument::ChangeContentEditableCount(nsIContent*, PRInt32)’:
content/html/document/src/nsHTMLDocument.cpp:2308:49: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
}

This is from this code...
> 2305 nsHTMLDocument::ChangeContentEditableCount(nsIContent *aElement,
> 2306                                            PRInt32 aChange)
> 2307 {
> 2308   NS_ASSERTION(mContentEditableCount + aChange >= 0,
> 2309                "Trying to decrement too much.");
...added in this cset: http://hg.mozilla.org/mozilla-central/rev/15cda702358e

mContentEditableCount is unsigned, so [mContentEditableCount + aChange] is unsigned and will always be >=0 by definition.  So the assertion doesn't check what it's trying to check.

Simplest/cleanest fix is probably to just add a PRInt32 cast.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/projects/birch/rev/5da92b15cfeb

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5da92b15cfeb