747494 - Consider HTTP 415 on invalid media type

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Gregory Szorc [:gps]]

Currently when the client issues a request with an improper media type via Content-Type (e.g. POST storage/collection/foo with Content-Type: application/octet-stream -- as tested in test_set_collection_input_formats), the server responds with a 400.

HTTP has a dedicated status code for this: 415 Unsupported Media Type.

I propose changing the spec and server implementation to send this instead of a 400.

Comment 1

[Ryan Kelly [:rfkelly]]

So it does, I'll make the change.

Comment 2

[Ryan Kelly [:rfkelly]]

Attachment: docs pach adding 415 response code

Comment 3

[Ryan Kelly [:rfkelly]]

Attachment: code pach adding 415 response code

This adds 415-Unsupported-Media-Type to both POST /storage/collection and PUT /storage/collection/id.  The latter previously had no explicit checking of the content-type header.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 617365 [details] [diff] [review]
docs pach adding 415 response code

Review of attachment 617365 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: source/spelling_wordlist.txt
@@ +72,4 @@
>  json
>  keyexchange
>  KeyExchange
> +kibibypes

"bypes" ?

Comment 5

[Toby Elliott [:telliott]]

Comment on attachment 617366 [details] [diff] [review]
code pach adding 415 response code

This is fine, but I think it should get rolled into cornice eventually. You specify acceptable media types somewhere and it magically gives you this.

Comment 6

[Tarek Ziadé (:tarek)]

Yeah good idea - https://github.com/mozilla-services/circus/issues/95

Comment 7

[Ryan Kelly [:rfkelly]]

https://github.com/mozilla-services/server-syncstorage/commit/915b6a9a5608424cec8c8763a1f1970862de6955