Uevent Poller causes compile error when built debug due to ScopedClose member change

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: qdot, Assigned: qdot)

Tracking

Trunk
mozilla14
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There's an assert in hal/gonk/UeventPoller.cpp:143 (landed in bug 742226) that uses a ScopedClose with .mFd member instead of .get(). This causes gecko to not compile in debug mode. 

This didn't burn any trees because we only compile release B2g on try currently. :( :( :(
(Assignee)

Comment 1

5 years ago
Created attachment 617109 [details] [diff] [review]
Change .mFd to .get() in Uevent poller assert
Attachment #617109 - Flags: review?(mwu)

Updated

5 years ago
Attachment #617109 - Flags: review?(mwu) → review+
(Assignee)

Comment 2

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/85a3c4509d28
https://hg.mozilla.org/mozilla-central/rev/85a3c4509d28
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.