Closed Bug 747547 Opened 11 years ago Closed 11 years ago

SUT agent: set permissions on pushed files

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Platform:
x86
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

set pushed file and directory permissions to 777
2.33 KB, patch
jmaher
: review+
Details | Diff | Splinter Review 
Remote files created with SUT agent's Push command are created with default permissions (I typically see rw-------). This causes a problem for xpcshell tests: xpcshell must be executable.

Note also that devicemanagerADB's pushFile calls 'chmod 777' on each remote file.

Unless there are security concerns, I would like to attempt to set all pushed files permissions to 777.
OS: Mac OS X → Android
Blocks: 747162
Attachment #618338 - Flags: review?(jmaher)
Comment on attachment 618338 [details] [diff] [review]
set pushed file and directory permissions to 777

Review of attachment 618338 [details] [diff] [review]:
-----------------------------------------------------------------

looks pretty straightforward.
Attachment #618338 - Flags: review?(jmaher) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/7df3e686913a
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/7df3e686913a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.