remove collector extension hooks from code

RESOLVED FIXED

Status

addons.mozilla.org Graveyard
Code Quality
P5
trivial
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: clouserw, Assigned: mat)

Tracking

Details

(Reporter)

Description

6 years ago
The collector extension is no longer maintained, we should remove anything we support for it from the code. Sync'd collections come to mind (database tables) - there might be some other stuff in the models.
(Reporter)

Comment 1

4 years ago
I'm pretty sure we could close this if we just deleted all the code that pops up when we grep for SyncedCollection and then dropped the synced_collections table.  There is also a cron job called cleanup_synced_collections that is still running every day which we should remove from scripts/crontab/crontab.tpl
Severity: normal → trivial
Priority: -- → P5

Updated

2 years ago
Assignee: nobody → mpillard
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
Iteration: --- → 46.1 - Dec 28
(Assignee)

Updated

2 years ago
Iteration: 46.1 - Dec 28 → 45.3 - Dec 14
(Assignee)

Comment 2

2 years ago
Fixed in https://github.com/mozilla/olympia/commit/795c8a8aa9bdbbed028b35d017eec9fc6c61e2e1

QA: check that the discovery pane is still working, logged in and out.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Comment 3

2 years ago
(In reply to Mathieu Pillard [:mat] from comment #2)
> Fixed in
> https://github.com/mozilla/olympia/commit/
> 795c8a8aa9bdbbed028b35d017eec9fc6c61e2e1
> 
> QA: check that the discovery pane is still working, logged in and out.

Mat, we have this issue https://github.com/mozilla/olympia/issues/1148 , should we reopen this bug?
Flags: needinfo?(mpillard)
(Assignee)

Comment 4

2 years ago
That's a pretty bad bug but it doesn't seem linked to my changes.
Flags: needinfo?(mpillard)
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.