747657 - Convert feeds to FileUtils.jsm; remove file-utils.js

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, enhancement)

Comment 1

[alta88]

Attachment: patch.

Comment 2

[Ludovic Hirlimann [:Usul]]

hoping the review is set to the proper magnus ...

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 617237 [details] [diff] [review]
patch.

No, that's not me.
I'll note that this patch doesn't apply cleanly to trunk. Also, as this is mailnews/ and not mail/ i'm not an official reviewer for it.

Comment 4

[alta88]

Comment on attachment 617237 [details] [diff] [review]
patch.


this patch had a dependency, as noted, on bug 721517.

Comment 5

[David :Bienvenu]

Comment on attachment 617237 [details] [diff] [review]
patch.

apologies for not getting to this sooner; it has bit-rotted; do you have an updated version of it?

Comment 6

[alta88]

are you sure it's bit rot (don't think anyone else is working in feeds), or needing the dependency per comment 4?  that bug touches so much, it really needs to go first.

Comment 7

[David :Bienvenu]

(In reply to alta88 from comment #6)
> are you sure it's bit rot (don't think anyone else is working in feeds), or
> needing the dependency per comment 4?  that bug touches so much, it really
> needs to go first.

most likely, yes.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

After you refresh the patch in bug 721517, please make sure that this patch still applies cleanly and update it if need be. Thanks!

Comment 9

[alta88]

this one looks good.  thanks.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/961effd85cf6

Comment 11

[alta88]

Comment on attachment 617237 [details] [diff] [review]
patch.

[Approval Request Comment]

this bug 747657 and bug 721517 mark the end of the (somewhat massive) feeds renovation.  Ludo has indicated to me that he would like to hold an organized test day using the Aurora release.  imo it would be best to include these 2 bugs in Aurora to leverage the test day.  they are almost exclusively code housekeeping, but touch all parts of feeds.

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 617237 [details] [diff] [review]
patch.

Sorry for not getting to this earlier. Unfortunately we also missed the test-day. Therefore I think we'll not advance this forward, but let it get testing through the release trains.