The default bug view has changed. See this FAQ.

Convert feeds to FileUtils.jsm; remove file-utils.js

RESOLVED FIXED in Thunderbird 15.0

Status

MailNews Core
Feed Reader
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alta88, Assigned: alta88)

Tracking

unspecified
Thunderbird 15.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 617237 [details] [diff] [review]
patch.
Assignee: nobody → alta88
Attachment #617237 - Flags: review?(magnus)
(Assignee)

Updated

5 years ago
Depends on: 721517
hoping the review is set to the proper magnus ...

Comment 3

5 years ago
Comment on attachment 617237 [details] [diff] [review]
patch.

No, that's not me.
I'll note that this patch doesn't apply cleanly to trunk. Also, as this is mailnews/ and not mail/ i'm not an official reviewer for it.
Attachment #617237 - Flags: review?(magnus)
(Assignee)

Comment 4

5 years ago
Comment on attachment 617237 [details] [diff] [review]
patch.


this patch had a dependency, as noted, on bug 721517.
Attachment #617237 - Flags: review?(dbienvenu)

Comment 5

5 years ago
Comment on attachment 617237 [details] [diff] [review]
patch.

apologies for not getting to this sooner; it has bit-rotted; do you have an updated version of it?
Attachment #617237 - Flags: review?(dbienvenu)
(Assignee)

Comment 6

5 years ago
are you sure it's bit rot (don't think anyone else is working in feeds), or needing the dependency per comment 4?  that bug touches so much, it really needs to go first.

Comment 7

5 years ago
(In reply to alta88 from comment #6)
> are you sure it's bit rot (don't think anyone else is working in feeds), or
> needing the dependency per comment 4?  that bug touches so much, it really
> needs to go first.

most likely, yes.

Updated

5 years ago
Attachment #617237 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
After you refresh the patch in bug 721517, please make sure that this patch still applies cleanly and update it if need be. Thanks!
(Assignee)

Comment 9

5 years ago
this one looks good.  thanks.
http://hg.mozilla.org/comm-central/rev/961effd85cf6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
(Assignee)

Comment 11

5 years ago
Comment on attachment 617237 [details] [diff] [review]
patch.

[Approval Request Comment]

this bug 747657 and bug 721517 mark the end of the (somewhat massive) feeds renovation.  Ludo has indicated to me that he would like to hold an organized test day using the Aurora release.  imo it would be best to include these 2 bugs in Aurora to leverage the test day.  they are almost exclusively code housekeeping, but touch all parts of feeds.
Attachment #617237 - Flags: approval-comm-aurora?
Comment on attachment 617237 [details] [diff] [review]
patch.

Sorry for not getting to this earlier. Unfortunately we also missed the test-day. Therefore I think we'll not advance this forward, but let it get testing through the release trains.
Attachment #617237 - Flags: approval-comm-aurora? → approval-comm-aurora-
You need to log in before you can comment on or make changes to this bug.