Last Comment Bug 747657 - Convert feeds to FileUtils.jsm; remove file-utils.js
: Convert feeds to FileUtils.jsm; remove file-utils.js
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Feed Reader (show other bugs)
: unspecified
: All All
: -- enhancement (vote)
: Thunderbird 15.0
Assigned To: alta88
:
Mentors:
Depends on: 721517
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-21 10:55 PDT by alta88
Modified: 2012-06-12 03:09 PDT (History)
6 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch. (25.83 KB, patch)
2012-04-21 11:00 PDT, alta88
mozilla: review+
standard8: approval‑comm‑aurora-
Details | Diff | Splinter Review

Description alta88 2012-04-21 10:55:50 PDT

    
Comment 1 alta88 2012-04-21 11:00:48 PDT
Created attachment 617237 [details] [diff] [review]
patch.
Comment 2 Ludovic Hirlimann [:Usul] 2012-04-23 05:28:08 PDT
hoping the review is set to the proper magnus ...
Comment 3 Magnus Melin 2012-04-23 12:04:28 PDT
Comment on attachment 617237 [details] [diff] [review]
patch.

No, that's not me.
I'll note that this patch doesn't apply cleanly to trunk. Also, as this is mailnews/ and not mail/ i'm not an official reviewer for it.
Comment 4 alta88 2012-04-23 12:10:15 PDT
Comment on attachment 617237 [details] [diff] [review]
patch.


this patch had a dependency, as noted, on bug 721517.
Comment 5 David :Bienvenu 2012-04-30 11:24:06 PDT
Comment on attachment 617237 [details] [diff] [review]
patch.

apologies for not getting to this sooner; it has bit-rotted; do you have an updated version of it?
Comment 6 alta88 2012-04-30 11:54:04 PDT
are you sure it's bit rot (don't think anyone else is working in feeds), or needing the dependency per comment 4?  that bug touches so much, it really needs to go first.
Comment 7 David :Bienvenu 2012-04-30 12:09:22 PDT
(In reply to alta88 from comment #6)
> are you sure it's bit rot (don't think anyone else is working in feeds), or
> needing the dependency per comment 4?  that bug touches so much, it really
> needs to go first.

most likely, yes.
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-05-01 17:00:37 PDT
After you refresh the patch in bug 721517, please make sure that this patch still applies cleanly and update it if need be. Thanks!
Comment 9 alta88 2012-05-01 17:56:49 PDT
this one looks good.  thanks.
Comment 10 Ryan VanderMeulen [:RyanVM] 2012-05-01 17:59:06 PDT
http://hg.mozilla.org/comm-central/rev/961effd85cf6
Comment 11 alta88 2012-05-02 11:04:04 PDT
Comment on attachment 617237 [details] [diff] [review]
patch.

[Approval Request Comment]

this bug 747657 and bug 721517 mark the end of the (somewhat massive) feeds renovation.  Ludo has indicated to me that he would like to hold an organized test day using the Aurora release.  imo it would be best to include these 2 bugs in Aurora to leverage the test day.  they are almost exclusively code housekeeping, but touch all parts of feeds.
Comment 12 Mark Banner (:standard8) 2012-06-12 03:09:09 PDT
Comment on attachment 617237 [details] [diff] [review]
patch.

Sorry for not getting to this earlier. Unfortunately we also missed the test-day. Therefore I think we'll not advance this forward, but let it get testing through the release trains.

Note You need to log in before you can comment on or make changes to this bug.