Closed
Bug 747800
Opened 12 years ago
Closed 12 years ago
Fix code causing |Warning: function xyz does not always return a value|
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 15.0
People
(Reporter: squib, Assigned: squib)
Details
Attachments
(1 file)
6.90 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
There are a bunch of spots in our code that throw |Warning: function xyz does not always return a value|. Let's fix them so as to reduce the messiness in the Error Console. This has been annoying me lately, as I've been trying to fix startup issues in an add-on, and I always have to scroll past this stuff.
Attachment #617351 -
Flags: review?(mbanner)
Comment 1•12 years ago
|
||
Comment on attachment 617351 [details] [diff] [review] Remove these warnings Review of attachment 617351 [details] [diff] [review]: ----------------------------------------------------------------- Please can you generate -p patches (showfunc) in future, it helps with locating the functions that you're changing. Otherwise looks good.
Attachment #617351 -
Flags: review?(mbanner) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/076c3f2bbb9b (And hgrc updated to show functions in diffs.)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
This is great. If you spot any similar warnings in the Account manager that are not covered in bug 738810, please assign them to me :)
Comment 4•12 years ago
|
||
Thanks for fixing this, I'm annoyed too by warnings at startup :-). I would appreciate being CC'ed to bugs with patches touching chat/, as these also need to be applied to the upstream Instantbird repository.
You need to log in
before you can comment on or make changes to this bug.
Description
•