The default bug view has changed. See this FAQ.

Add Win 64 bit mozconfigs and fix Mac universal mozconfigs

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

13 Branch
Thunderbird 14.0
x86
Mac OS X
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird13 fixed, thunderbird-esr1013+ fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 617426 [details] [diff] [review]
The fix

Now that bug 747025 is getting in full flow, we're starting to get builders out and running.

From the nightlies we've had running so far, we need:

- Win64 bit mozconfigs (although these aren't going to be official builds yet, having some trunk ones is what we want to match with FF and aid any development work).
- Adjust Mac universal mozconfigs. The issue here is that the mozilla/ sub-directory isn't available when these are needed. Therefore we need to copy across from the Firefox directory the bits we need, this also allows us to remove most of the hacks that we've needed for the different location according to topsrcdir.

In the Win64 mozconfigs, I've had to do a bit of a hack again as the vs2010-mozconfig isn't in a common directory. I'm going to file a bug on making that common (i.e. in a build/ subdir), and when we do, we can do the same in c-c.

I'll take whoever gets to the review first.
Attachment #617426 - Flags: review?(jhopkins)
Attachment #617426 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 1

5 years ago
(In reply to Mark Banner (:standard8) from comment #0)
> In the Win64 mozconfigs, I've had to do a bit of a hack again as the
> vs2010-mozconfig isn't in a common directory. I'm going to file a bug on
> making that common (i.e. in a build/ subdir), and when we do, we can do the
> same in c-c.

Bug 747860 raised.
Attachment #617426 - Flags: review?(jhopkins) → review+
(Assignee)

Updated

5 years ago
Attachment #617426 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 2

5 years ago
Checked in with a few follow-ups agreed over irc:

http://hg.mozilla.org/comm-central/rev/9427206297fe
http://hg.mozilla.org/comm-central/rev/3456f7a95ce2
http://hg.mozilla.org/comm-central/rev/16341689f26d
http://hg.mozilla.org/comm-central/rev/bf51adb4d383
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
(Assignee)

Comment 3

5 years ago
Comment on attachment 617426 [details] [diff] [review]
The fix

[Triage Comment]
Also going to take these currently NPOTB parts across to aurora as we'll need them over there as well.
Attachment #617426 - Flags: approval-comm-aurora+
(Assignee)

Comment 4

5 years ago
Checked in on aurora:

http://hg.mozilla.org/releases/comm-aurora/rev/214a49809be5
http://hg.mozilla.org/releases/comm-aurora/rev/ab7c6acda736
http://hg.mozilla.org/releases/comm-aurora/rev/518c9f74b316
http://hg.mozilla.org/releases/comm-aurora/rev/07731fc05f13
status-thunderbird13: --- → fixed
(Assignee)

Comment 5

5 years ago
Comment on attachment 617426 [details] [diff] [review]
The fix

[Triage Comment]
Need to sync this to ESR so that we can run the new build systems there as well.
Attachment #617426 - Flags: approval-comm-esr10+
(Assignee)

Comment 6

5 years ago
Checked in:

https://hg.mozilla.org/releases/comm-esr10/rev/1470f03ccaaa
https://hg.mozilla.org/releases/comm-esr10/rev/bc357c5e71d8
https://hg.mozilla.org/releases/comm-esr10/rev/58684df29f54
https://hg.mozilla.org/releases/comm-esr10/rev/b5c494af8f39
status-thunderbird-esr10: --- → fixed
tracking-thunderbird-esr10: --- → 13+
You need to log in before you can comment on or make changes to this bug.