Closed Bug 747896 Opened 8 years ago Closed 8 years ago

Remove hardcoded space inserted before success.title.after (accountProvisioner.dtd)

Categories

(Thunderbird :: Account Manager, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 14.0

People

(Reporter: stef, Assigned: aceman)

References

()

Details

(Keywords: polish)

Attachments

(1 file)

Originally reported as Aviary.pl bug 4336.

There is hardocoded space inserted before success.title.after label which is problematic when one wants to use sth like comma after login name. (affects l10n and en-US)

http://bugs.aviary.pl/attachment.cgi?id=2042
The sentence is like this:
&success.title.before;<FirstName> <LastName>&success.title.after; .
The order and also the space is hardcoded.
Have you left FirstName or LastName blank when you created the account?
The whole string could probably be refined into one string with a placeholder for the name so that localizers can play with the position. Were this not in some jquery code I could probably do it.
Component: General → Account Manager
QA Contact: general → account-manager
Version: unspecified → Trunk
I don't see FirstName and LastName fields on fresh start or when getting new account…
I only see one field, "Your name, or nickname" with search button on the right.
Maybe that is the problem.
OK, I tested it and I can confirm the problem.

The input box placeholder text says "Your name, or nickname". But the code of the dialog in several places splits the input text into a firstName and lastName. And then it often contatenates them together with a space so that if lastname is empty a trailing space will remain.
Severity: normal → minor
Keywords: polish
OS: Mac OS X → All
Hardware: x86 → All
Attached patch patchSplinter Review
The attached patch removes the potential trailing space (via .trim) in two places. It does not change the logic wrt. the existing code already coping with empty last name.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #617530 - Flags: review?(mconley)
Comment on attachment 617530 [details] [diff] [review]
patch

Review of attachment 617530 [details] [diff] [review]:
-----------------------------------------------------------------

This looks right to me.

Thanks aceman!
Attachment #617530 - Flags: review?(mconley) → review+
Keywords: checkin-needed
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/968ca62d7854
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.