The default bug view has changed. See this FAQ.

Remove hardcoded space inserted before success.title.after (accountProvisioner.dtd)

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Account Manager
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: stef, Assigned: aceman)

Tracking

({polish})

Trunk
Thunderbird 14.0
polish

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Originally reported as Aviary.pl bug 4336.

There is hardocoded space inserted before success.title.after label which is problematic when one wants to use sth like comma after login name. (affects l10n and en-US)

http://bugs.aviary.pl/attachment.cgi?id=2042
(Assignee)

Comment 1

5 years ago
The sentence is like this:
&success.title.before;<FirstName> <LastName>&success.title.after; .
The order and also the space is hardcoded.
Have you left FirstName or LastName blank when you created the account?
The whole string could probably be refined into one string with a placeholder for the name so that localizers can play with the position. Were this not in some jquery code I could probably do it.
Component: General → Account Manager
QA Contact: general → account-manager
Version: unspecified → Trunk
(Reporter)

Comment 2

5 years ago
I don't see FirstName and LastName fields on fresh start or when getting new account…
I only see one field, "Your name, or nickname" with search button on the right.
(Assignee)

Comment 3

5 years ago
Maybe that is the problem.
(Assignee)

Comment 4

5 years ago
OK, I tested it and I can confirm the problem.

The input box placeholder text says "Your name, or nickname". But the code of the dialog in several places splits the input text into a firstName and lastName. And then it often contatenates them together with a space so that if lastname is empty a trailing space will remain.
Severity: normal → minor
Keywords: polish
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 5

5 years ago
Created attachment 617530 [details] [diff] [review]
patch

The attached patch removes the potential trailing space (via .trim) in two places. It does not change the logic wrt. the existing code already coping with empty last name.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #617530 - Flags: review?(mconley)
Comment on attachment 617530 [details] [diff] [review]
patch

Review of attachment 617530 [details] [diff] [review]:
-----------------------------------------------------------------

This looks right to me.

Thanks aceman!
Attachment #617530 - Flags: review?(mconley) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/968ca62d7854
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.