Add a "Try Run" checkbox to Autoland Interface

RESOLVED WONTFIX

Status

()

bugzilla.mozilla.org
Extensions: TryAutoLand
--
enhancement
RESOLVED WONTFIX
6 years ago
4 years ago

People

(Reporter: mjessome, Assigned: dkl)

Tracking

Development

Details

(Reporter)

Description

6 years ago
Wanted to get some patches earlier this week, then we realized a usage case that we don't address (and will also need the ui for).
Would it be possible to have a check box for "Try Run" added ABOVE the branches box, that defaults to checked?

The idea behind this is that users will be able to disable a try run going before a landing to a branch. We were originally only targeting landing to try and then to branch on a successful try-run, then realized that this may not _always_ be desired.

As far as form-validation goes, we were thinking this:
- If "Try Run" is checked, nothing is required in the branches field.
- If "Try Run" is NOT checked, branches field must have a value (this can even be "try", it doesn't matter at all.
- If "Try Run" NOT specified, then the try syntax is not required.

This interface is the best we've been able to come up with, so changes are welcome.
(Assignee)

Comment 1

6 years ago
I am on PTO for the better part of this week due to a housing move. Is this something that is critical to be completed before next week? If yes, Byron (glob) could make a go at it, otherwise I can get to it as soon as Monday.

dkl
(Reporter)

Comment 2

6 years ago
This is something that would be awesome to have by Friday, since that will be the last day of my internship. Otherwise, I would just have to make sure that things are working okay on my side and hope that it will work with a test run or two early next week.

If that is the case, I would like to get the details of what is sent back so that I can code this without needing to make changes next week.

Thanks
As Marc mentioned, this is the last week of his internship - getting this box in will allow us to do branch landings much easier and get the Autoland system to a good place where it can rest for a bit (how sad when interns leave).

If it's possible for Byron to do it this week - even if just in staging, with a deploy to production later - that would be very very awesome.
Depends on: 749050
i'll attempt to get some action on this some time this week, but unfortunately i can't make any promises.

> As far as form-validation goes, we were thinking this:
> - If "Try Run" is checked, nothing is required in the branches field.
> - If "Try Run" is NOT checked, branches field must have a value (this can
> even be "try", it doesn't matter at all.
> - If "Try Run" NOT specified, then the try syntax is not required.

what's the difference between "not checked" and "not specified" .. isn't "try run" a checkbox?
(Reporter)

Comment 5

6 years ago
(In reply to Byron Jones ‹:glob› from comment #4)
> i'll attempt to get some action on this some time this week, but
> unfortunately i can't make any promises.
> 
> > As far as form-validation goes, we were thinking this:
> > - If "Try Run" is checked, nothing is required in the branches field.
> > - If "Try Run" is NOT checked, branches field must have a value (this can
> > even be "try", it doesn't matter at all.
> > - If "Try Run" NOT specified, then the try syntax is not required.
> 
> what's the difference between "not checked" and "not specified" .. isn't
> "try run" a checkbox?

My mistake, they are both the same. Those last two conditions are for the Try Run checkbox not being checked.
(Assignee)

Comment 6

6 years ago
(In reply to Marc Jessome[:mjessome] from comment #5)
> (In reply to Byron Jones ‹:glob› from comment #4)
> > i'll attempt to get some action on this some time this week, but
> > unfortunately i can't make any promises.
> > 
> > > As far as form-validation goes, we were thinking this:
> > > - If "Try Run" is checked, nothing is required in the branches field.
> > > - If "Try Run" is NOT checked, branches field must have a value (this can
> > > even be "try", it doesn't matter at all.
> > > - If "Try Run" NOT specified, then the try syntax is not required.
> > 
> > what's the difference between "not checked" and "not specified" .. isn't
> > "try run" a checkbox?
> 
> My mistake, they are both the same. Those last two conditions are for the
> Try Run checkbox not being checked.

Ok to clarify since i am working on this now:

- If "Try Run" IS checked, nothing is required in the branches field but a value in syntax is required.
- If "Try Run" IS NOT checked, branches field must have a value (this can
  even be "try", it doesn't matter at all) but syntax is optional and not required.

sound right?
Assignee: nobody → dkl
Status: NEW → ASSIGNED
(Reporter)

Comment 7

6 years ago
Yes, that is correct. Thanks

Comment 8

4 years ago
This is really old, and I think AutoLand has changed sufficiently that this may no longer be valid.  Please reopen if otherwise.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.