Last Comment Bug 747919 - browser/devtools/layoutview/test/browser_layoutview.js leaks chrome and content windows
: browser/devtools/layoutview/test/browser_layoutview.js leaks chrome and conte...
Status: RESOLVED FIXED
: intermittent-failure, mlk, regression
Product: Firefox
Classification: Client Software
Component: Developer Tools: Inspector (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 15
Assigned To: Paul Rouget [:paul]
:
Mentors:
Depends on:
Blocks: 438871 683954 734554
  Show dependency treegraph
 
Reported: 2012-04-23 08:10 PDT by Dão Gottwald [:dao]
Modified: 2012-11-25 19:31 PST (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
fixed


Attachments
patch v1 (957 bytes, patch)
2012-04-25 07:54 PDT, Paul Rouget [:paul]
dao+bmo: review+
Details | Diff | Splinter Review

Description Dão Gottwald [:dao] 2012-04-23 08:10:02 PDT
[browser/devtools/layoutview/test/browser_layoutview.js]
  2 window(s) [url = chrome://browser/content/devtools/layoutview/view.xhtml]
  1 window(s) [url = about:blank]
  1 window(s) [url = data:text/html,%3Cstyle%3Ediv%20%7B%20position%3A%20absolute%3B%20top%3A%2042px%3B%20left%3A%2042px%3B%20height%3A%20100px%3B%20width%3A%20100px%3B%20border%3A%2010px%20solid%20black%3B%20padding%3A%2020px%3B%20margin%3A%2030px%3B%20%7D%3C%2Fstyle%3E%3Cdiv%3E%3C%2Fdiv%3E]

Paul, can you take this?
Comment 1 Paul Rouget [:paul] 2012-04-23 12:04:39 PDT
(In reply to Dão Gottwald [:dao] from comment #0)
> Paul, can you take this?

Yes. Thank you.
Comment 8 Paul Rouget [:paul] 2012-04-25 07:54:10 PDT
Created attachment 618259 [details] [diff] [review]
patch v1
Comment 9 Paul Rouget [:paul] 2012-04-25 07:59:23 PDT
Apparently, this fixes the problem: https://tbpl.mozilla.org/?tree=Try&rev=a4aa2a563208
Comment 32 Dão Gottwald [:dao] 2012-04-26 06:43:52 PDT
http://hg.mozilla.org/mozilla-central/rev/c6d998a2cc8c
Comment 33 Rob Campbell [:rc] (:robcee) 2012-04-26 06:57:17 PDT
ugh. and I just pushed it to fx-team. Will backout.
Comment 34 Dão Gottwald [:dao] 2012-04-26 07:00:28 PDT
No need to back it out.
Comment 53 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-04-27 05:51:53 PDT
https://hg.mozilla.org/mozilla-central/rev/309a40ba4906
Comment 57 :Ehsan Akhgari 2012-05-02 13:25:34 PDT
This patch was in a range which caused a Ts regression, so I backed out the whole range:

https://hg.mozilla.org/mozilla-central/rev/24a6a53c714a

Please reland after investigating and fixing the regression.
Comment 58 Dão Gottwald [:dao] 2012-05-02 13:44:57 PDT
(In reply to Ehsan Akhgari [:ehsan] from comment #57)
> This patch was in a range which caused a Ts regression, so I backed out the
> whole range:
> 
> https://hg.mozilla.org/mozilla-central/rev/24a6a53c714a

This didn't actually back this bug's patch out.

Note You need to log in before you can comment on or make changes to this bug.