Closed Bug 747919 Opened 12 years ago Closed 12 years ago

browser/devtools/layoutview/test/browser_layoutview.js leaks chrome and content windows

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox14 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 15
Tracking Flags:
Tracking Status
firefox14 --- fixed

People

(Reporter: dao, Assigned: paul)

References

Details

(Keywords: intermittent-failure, memory-leak, regression)

Attachments

(1 file)

patch v1
957 bytes, patch
dao
: review+
Details | Diff | Splinter Review 
[browser/devtools/layoutview/test/browser_layoutview.js]
  2 window(s) [url = chrome://browser/content/devtools/layoutview/view.xhtml]
  1 window(s) [url = about:blank]
  1 window(s) [url = data:text/html,%3Cstyle%3Ediv%20%7B%20position%3A%20absolute%3B%20top%3A%2042px%3B%20left%3A%2042px%3B%20height%3A%20100px%3B%20width%3A%20100px%3B%20border%3A%2010px%20solid%20black%3B%20padding%3A%2020px%3B%20margin%3A%2030px%3B%20%7D%3C%2Fstyle%3E%3Cdiv%3E%3C%2Fdiv%3E]

Paul, can you take this?
Summary: browser/devtools/layoutview/test/browser_layoutview.js leaks DOM windows → browser/devtools/layoutview/test/browser_layoutview.js leaks chrome and content windows
(In reply to Dão Gottwald [:dao] from comment #0)
> Paul, can you take this?

Yes. Thank you.
Assignee: nobody → paul
Blocks: 438871
Whiteboard: [orange]
Attached patch patch v1 — — Splinter Review 

    
  

        Attachment #618259 -
        Flags: review?(dao)

    
    

    
  
Apparently, this fixes the problem: https://tbpl.mozilla.org/?tree=Try&rev=a4aa2a563208

    
  

        Attachment #618259 -
        Flags: review?(dao) → review+

    
  
Whiteboard: [orange] → [orange][land-in-fx-team]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/c6d998a2cc8c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [orange][land-in-fx-team] → [orange]
Target Milestone: --- → Firefox 15

    
    

    
  
ugh. and I just pushed it to fx-team. Will backout.
Whiteboard: [orange] → [orange][fixed-in-fx-team]
Target Milestone: Firefox 15 → ---

    
    

    
  
No need to back it out.
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Target Milestone: --- → Firefox 15

    
    

    
  
This patch was in a range which caused a Ts regression, so I backed out the whole range:

https://hg.mozilla.org/mozilla-central/rev/24a6a53c714a

Please reland after investigating and fixing the regression.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
(In reply to Ehsan Akhgari [:ehsan] from comment #57)
> This patch was in a range which caused a Ts regression, so I backed out the
> whole range:
> 
> https://hg.mozilla.org/mozilla-central/rev/24a6a53c714a

This didn't actually back this bug's patch out.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Whiteboard: [orange]

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: