browser/devtools/layoutview/test/browser_layoutview.js leaks chrome and content windows

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: paul)

Tracking

({intermittent-failure, mlk, regression})

Trunk
Firefox 15
intermittent-failure, mlk, regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox14 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
[browser/devtools/layoutview/test/browser_layoutview.js]
  2 window(s) [url = chrome://browser/content/devtools/layoutview/view.xhtml]
  1 window(s) [url = about:blank]
  1 window(s) [url = data:text/html,%3Cstyle%3Ediv%20%7B%20position%3A%20absolute%3B%20top%3A%2042px%3B%20left%3A%2042px%3B%20height%3A%20100px%3B%20width%3A%20100px%3B%20border%3A%2010px%20solid%20black%3B%20padding%3A%2020px%3B%20margin%3A%2030px%3B%20%7D%3C%2Fstyle%3E%3Cdiv%3E%3C%2Fdiv%3E]

Paul, can you take this?
(Reporter)

Updated

5 years ago
Summary: browser/devtools/layoutview/test/browser_layoutview.js leaks DOM windows → browser/devtools/layoutview/test/browser_layoutview.js leaks chrome and content windows
(Assignee)

Comment 1

5 years ago
(In reply to Dão Gottwald [:dao] from comment #0)
> Paul, can you take this?

Yes. Thank you.
Assignee: nobody → paul

Comment 2

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=11129872&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=11148791&tree=Birch
https://tbpl.mozilla.org/php/getParsedLog.php?id=11126084&tree=Birch
(Reporter)

Updated

5 years ago
Blocks: 438871
Whiteboard: [orange]

Comment 3

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=11158224&tree=Birch

Comment 4

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=11160887&tree=Fx-Team

Comment 5

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=11163201&tree=Birch

Comment 6

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=11161912&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11186419&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11184226&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11181878&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11179835&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11173092&tree=Mozilla-Inbound
(Assignee)

Comment 8

5 years ago
Created attachment 618259 [details] [diff] [review]
patch v1
(Assignee)

Updated

5 years ago
Attachment #618259 - Flags: review?(dao)
(Assignee)

Comment 9

5 years ago
Apparently, this fixes the problem: https://tbpl.mozilla.org/?tree=Try&rev=a4aa2a563208
https://tbpl.mozilla.org/php/getParsedLog.php?id=11195048&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11195355&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11194839&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11196365&tree=Fx-Team
(Reporter)

Updated

5 years ago
Attachment #618259 - Flags: review?(dao) → review+
(Assignee)

Updated

5 years ago
Whiteboard: [orange] → [orange][land-in-fx-team]
https://tbpl.mozilla.org/php/getParsedLog.php?id=11197748&tree=Mozilla-Aurora
status-firefox14: --- → affected
https://tbpl.mozilla.org/php/getParsedLog.php?id=11198484&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11203709&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11204577&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11205374&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11205225&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11205692&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11206256&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11205888&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11210407&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11209636&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11216018&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11215376&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11218178&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11218459&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11216124&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11217847&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11215224&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11215272&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11220454&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11221123&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11222337&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11226551&tree=Mozilla-Inbound
(Reporter)

Comment 32

5 years ago
http://hg.mozilla.org/mozilla-central/rev/c6d998a2cc8c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [orange][land-in-fx-team] → [orange]
Target Milestone: --- → Firefox 15
ugh. and I just pushed it to fx-team. Will backout.
Whiteboard: [orange] → [orange][fixed-in-fx-team]
Target Milestone: Firefox 15 → ---
(Reporter)

Comment 34

5 years ago
No need to back it out.
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Target Milestone: --- → Firefox 15
https://tbpl.mozilla.org/php/getParsedLog.php?id=11235584&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11236103&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11236492&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11236916&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11238565&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11240966&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11240945&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11239965&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11242287&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11243368&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11248936&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11246862&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11250284&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11249744&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11246699&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11246242&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11253072&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11255035&tree=Mozilla-Aurora
https://hg.mozilla.org/mozilla-central/rev/309a40ba4906
https://tbpl.mozilla.org/php/getParsedLog.php?id=11273413&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11287172&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11286955&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11295416&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=11296038&tree=Mozilla-Aurora
(Reporter)

Comment 56

5 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/da65f130ceb2
status-firefox14: affected → fixed
This patch was in a range which caused a Ts regression, so I backed out the whole range:

https://hg.mozilla.org/mozilla-central/rev/24a6a53c714a

Please reland after investigating and fixing the regression.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 58

5 years ago
(In reply to Ehsan Akhgari [:ehsan] from comment #57)
> This patch was in a range which caused a Ts regression, so I backed out the
> whole range:
> 
> https://hg.mozilla.org/mozilla-central/rev/24a6a53c714a

This didn't actually back this bug's patch out.
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
https://tbpl.mozilla.org/php/getParsedLog.php?id=11452343&tree=Mozilla-Aurora
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.