browser/devtools/layoutview/test/browser_layoutview.js leaks chrome and content windows

RESOLVED FIXED in Firefox 14

Status

defect
RESOLVED FIXED
7 years ago
Last year

People

(Reporter: dao, Assigned: paul)

Tracking

({intermittent-failure, memory-leak, regression})

Dependency tree / graph

Firefox Tracking Flags

(firefox14 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

7 years ago
[browser/devtools/layoutview/test/browser_layoutview.js]
  2 window(s) [url = chrome://browser/content/devtools/layoutview/view.xhtml]
  1 window(s) [url = about:blank]
  1 window(s) [url = data:text/html,%3Cstyle%3Ediv%20%7B%20position%3A%20absolute%3B%20top%3A%2042px%3B%20left%3A%2042px%3B%20height%3A%20100px%3B%20width%3A%20100px%3B%20border%3A%2010px%20solid%20black%3B%20padding%3A%2020px%3B%20margin%3A%2030px%3B%20%7D%3C%2Fstyle%3E%3Cdiv%3E%3C%2Fdiv%3E]

Paul, can you take this?
Reporter

Updated

7 years ago
Summary: browser/devtools/layoutview/test/browser_layoutview.js leaks DOM windows → browser/devtools/layoutview/test/browser_layoutview.js leaks chrome and content windows
Assignee

Comment 1

7 years ago
(In reply to Dão Gottwald [:dao] from comment #0)
> Paul, can you take this?

Yes. Thank you.
Assignee: nobody → paul
Reporter

Updated

7 years ago
Blocks: 438871
Whiteboard: [orange]
Assignee

Comment 8

7 years ago
Posted patch patch v1Splinter Review
Assignee

Updated

7 years ago
Attachment #618259 - Flags: review?(dao)
Assignee

Comment 9

7 years ago
Apparently, this fixes the problem: https://tbpl.mozilla.org/?tree=Try&rev=a4aa2a563208
Reporter

Updated

7 years ago
Attachment #618259 - Flags: review?(dao) → review+
Assignee

Updated

7 years ago
Whiteboard: [orange] → [orange][land-in-fx-team]
Reporter

Comment 32

7 years ago
http://hg.mozilla.org/mozilla-central/rev/c6d998a2cc8c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [orange][land-in-fx-team] → [orange]
Target Milestone: --- → Firefox 15
ugh. and I just pushed it to fx-team. Will backout.
Whiteboard: [orange] → [orange][fixed-in-fx-team]
Target Milestone: Firefox 15 → ---
Reporter

Comment 34

7 years ago
No need to back it out.
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Target Milestone: --- → Firefox 15

Comment 57

7 years ago
This patch was in a range which caused a Ts regression, so I backed out the whole range:

https://hg.mozilla.org/mozilla-central/rev/24a6a53c714a

Please reland after investigating and fixing the regression.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter

Comment 58

7 years ago
(In reply to Ehsan Akhgari [:ehsan] from comment #57)
> This patch was in a range which caused a Ts regression, so I backed out the
> whole range:
> 
> https://hg.mozilla.org/mozilla-central/rev/24a6a53c714a

This didn't actually back this bug's patch out.
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Whiteboard: [orange]

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.