747947 - Implement an "http only" variation of selfserv (httpserv)

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Kai Engert [:KaiE:]]

In order to make the NSS_AIA testing fully self-contained,
without having to rely on an external HTTP server,
and without requiring that a separate HTTP server is installed on the build machine,
NSS should provide a minimal HTTP server.

In fact, selfserv already contains all of the functionality that we need for that.
It's just that selfserv is designed to be a server for HTTPS, only.

We have two choices to change this.

(a) copy selfserv code, and remove anything that's SSL specific

or

(b) use additional code to enable selfserv to allow as a plain HTTP server

Comment 1

[Kai Engert [:KaiE:]]

I have a patch that implements strategy (a), just because it was quicker for me to get it done this way.

Comment 2

[Kai Engert [:KaiE:]]

Attachment: Patch v1 --- add a separate httpserv executable [tested]

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Diff between selfserv.c and new httpserv.c

Above patch v1 introduces a new httpserv.c file.

This patch shows the differences between
  existing selfserv.c
and
  new httpserv.c

Most of it is removal.

Comment 4

[Kai Engert [:KaiE:]]

Do you prefer 

  (a) clearly distinguish HTTP and HTTPS server tools
      with code duplication

or

  (b) use a single selfserv tool that can do both HTTPS and HTTP,
      no code duplication,
      but more complicated usage of selfserv?

Comment 5

[Kai Engert [:KaiE:]]

Attachment: Patch B2 [untested]

Alternative implementation of the (b) approach.

Comment 6

[Kai Engert [:KaiE:]]

Bob, Wan-Teh,

please give me your opinion, whether we should go ahead with (a) and review patch v1,

or whether we should go route (b), which would require me to restart my testing with patch B2.

Comment 7

[Robert Relyea]

Comment on attachment 617519 [details] [diff] [review]
Patch v1  --- add a separate httpserv executable [tested]

r+ rrelyea.

Thanks for the diff patch between httpserv and selfserv.

bob

Comment 8

[Kai Engert [:KaiE:]]

Checking in manifest.mn;
/cvsroot/mozilla/security/nss/cmd/manifest.mn,v  <--  manifest.mn
new revision: 1.35; previous revision: 1.34
done
RCS file: /cvsroot/mozilla/security/nss/cmd/httpserv/Makefile,v
done
Checking in httpserv/Makefile;
/cvsroot/mozilla/security/nss/cmd/httpserv/Makefile,v  <--  Makefile
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/nss/cmd/httpserv/httpserv.c,v
done
Checking in httpserv/httpserv.c;
/cvsroot/mozilla/security/nss/cmd/httpserv/httpserv.c,v  <--  httpserv.c
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/nss/cmd/httpserv/manifest.mn,v
done
Checking in httpserv/manifest.mn;
/cvsroot/mozilla/security/nss/cmd/httpserv/manifest.mn,v  <--  manifest.mn
initial revision: 1.1
done