748009 - PerfConfigurator --configPath and --sampleConfig are not only redundant, theyre also b0rken

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

http://hg.mozilla.org/build/talos/file/61d1a38b5c75/talos/PerfConfigurator.py#l355

We have both --configPath and --sampleConfig, for no apparent reason,
with the latter being given an
absolute path default.  However, when you join them, any relative path
gets silently ignored (which is actually a python bug):

http://hg.mozilla.org/build/talos/file/61d1a38b5c75/talos/PerfConfigurator.py#l244

(Pdb) self.configPath
'sample.2.config'
(Pdb) self.sampleConfig
'/home/jhammel/mozilla/src/talos/src/talos/talos/sample.config'
(Pdb) path.join(self.configPath, self.sampleConfig)
'/home/jhammel/mozilla/src/talos/src/talos/talos/sample.config'

Comment 1

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

I vote for removing --configPath.  We use --sampleConfig in the majority of our buildbot based automation.

Comment 2

[Jeff Hammel]

taking this as it blocks me

Comment 3

[Jeff Hammel]

Attachment: remove --configPath

I'll probably roll this into bug 718062 for landing but would like to get a separate review and try run

Comment 4

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Comment on attachment 617552 [details] [diff] [review]
remove --configPath

Review of attachment 617552 [details] [diff] [review]:
-----------------------------------------------------------------

::: talos/PerfConfigurator.py
@@ +249,1 @@
>          config = configFile.readlines()

would be nice to puse the readlines inside the try statement as well.  Then we could put the close() in the except or a finally clause.

Comment 5

[Jeff Hammel]

Attachment: better exception handling

Comment 6

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Comment on attachment 617568 [details] [diff] [review]
better exception handling

Review of attachment 617568 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

Comment 7

[Jeff Hammel]

Planning on taking this as a ride-along to bug 718062 but if the latter gets bitrotted then might as well take this. Noting

Comment 8

[Mozilla RelEng Bot]

Try run for 409a3667bc7a is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=409a3667bc7a
Results (out of 80 total builds):
    exception: 7
    success: 72
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-409a3667bc7a

Comment 9

[Jeff Hammel]

These all look like infrastructure failures :(

Comment 10

[Jeff Hammel]

Fixed with the landing of bug 718062