Last Comment Bug 748066 - The attachment part of the preferences pane is very tall
: The attachment part of the preferences pane is very tall
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: Thunderbird 16.0
Assigned To: Andreas Nilsson (:andreasn)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-23 12:41 PDT by Andreas Nilsson (:andreasn)
Modified: 2012-06-19 15:27 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
changes the value to 15em instead (533 bytes, patch)
2012-04-23 13:08 PDT, Andreas Nilsson (:andreasn)
no flags Details | Diff | Splinter Review
change the value to 17em (518 bytes, patch)
2012-04-24 09:14 PDT, Andreas Nilsson (:andreasn)
mconley: review+
bwinton: ui‑review+
Details | Diff | Splinter Review
screenshot before (73.42 KB, image/png)
2012-04-24 09:20 PDT, Andreas Nilsson (:andreasn)
no flags Details
screenshot after (78.30 KB, image/png)
2012-04-24 09:21 PDT, Andreas Nilsson (:andreasn)
no flags Details

Description Andreas Nilsson (:andreasn) 2012-04-23 12:41:26 PDT
Compared to the other panes, the attachment pane is very tall.
Note that this is not because of the addition of Filelink, as this happens in the current stable version of Thunderbird as well, even though the content type thing is all empty.
Comment 1 Andreas Nilsson (:andreasn) 2012-04-23 12:55:56 PDT
Richard pointed me to this: http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/preferences/preferences.css#99
Comment 2 Andreas Nilsson (:andreasn) 2012-04-23 13:08:28 PDT
Created attachment 617609 [details] [diff] [review]
changes the value to 15em instead
Comment 3 Mike Conley (:mconley) 2012-04-24 06:40:45 PDT
Andreas:

Hm - this patch seems to cut the bottom of the tabpanel off for me.

See:  http://i.imgur.com/J5cUv.png

-Mike
Comment 4 Andreas Nilsson (:andreasn) 2012-04-24 06:50:40 PDT
(In reply to Mike Conley (:mconley) from comment #3)
> Andreas:
> 
> Hm - this patch seems to cut the bottom of the tabpanel off for me.
> 
> See:  http://i.imgur.com/J5cUv.png

It does for me too. I was blind last night, so I missed that we're supposed to have curves at the bottom.
Comment 5 Andreas Nilsson (:andreasn) 2012-04-24 09:14:36 PDT
Created attachment 617896 [details] [diff] [review]
change the value to 17em

Ehehe, no more cutoffs
Comment 6 Andreas Nilsson (:andreasn) 2012-04-24 09:20:35 PDT
Created attachment 617901 [details]
screenshot before
Comment 7 Andreas Nilsson (:andreasn) 2012-04-24 09:21:11 PDT
Created attachment 617902 [details]
screenshot after
Comment 8 Blake Winton (:bwinton) (:☕️) 2012-04-24 11:38:41 PDT
Comment on attachment 617896 [details] [diff] [review]
change the value to 17em

Based on the screenshots, ui-r=me!
Comment 9 Mike Conley (:mconley) 2012-04-25 06:42:06 PDT
Comment on attachment 617896 [details] [diff] [review]
change the value to 17em

Review of attachment 617896 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Thanks Andreas!
Comment 10 Mike Conley (:mconley) 2012-06-19 06:49:20 PDT
bump
Comment 11 Andreas Nilsson (:andreasn) 2012-06-19 09:02:03 PDT
marking for checkin
Comment 12 Ryan VanderMeulen [:RyanVM] 2012-06-19 15:27:24 PDT
https://hg.mozilla.org/comm-central/rev/9d0f0dd107b1

Note You need to log in before you can comment on or make changes to this bug.