Closed
Bug 748066
Opened 12 years ago
Closed 12 years ago
The attachment part of the preferences pane is very tall
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 16.0
People
(Reporter: andreasn, Assigned: andreasn)
Details
Attachments
(3 files, 1 obsolete file)
|
518 bytes,
patch
|
mconley
:
review+
bwinton
:
ui-review+
|
Details | Diff | Splinter Review |
|
73.42 KB,
image/png
|
Details | |
|
78.30 KB,
image/png
|
Details |
screenshot before
Compared to the other panes, the attachment pane is very tall. Note that this is not because of the addition of Filelink, as this happens in the current stable version of Thunderbird as well, even though the content type thing is all empty.
|
Assignee | |
Comment 1•12 years ago
|
||
Richard pointed me to this: http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/preferences/preferences.css#99
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Attachment #617609 -
Flags: ui-review?(bwinton)
Attachment #617609 -
Flags: review?(mconley)
|
||
Comment 3•12 years ago
|
||
Andreas: Hm - this patch seems to cut the bottom of the tabpanel off for me. See: http://i.imgur.com/J5cUv.png -Mike
|
|
Assignee | |
Comment 4•12 years ago
|
||
(In reply to Mike Conley (:mconley) from comment #3) > Andreas: > > Hm - this patch seems to cut the bottom of the tabpanel off for me. > > See: http://i.imgur.com/J5cUv.png It does for me too. I was blind last night, so I missed that we're supposed to have curves at the bottom.
|
|
Assignee | |
Comment 5•12 years ago
|
||
Ehehe, no more cutoffs
Attachment #617609 -
Attachment is obsolete: true
Attachment #617609 -
Flags: ui-review?(bwinton)
Attachment #617609 -
Flags: review?(mconley)
Attachment #617896 -
Flags: ui-review?(bwinton)
Attachment #617896 -
Flags: review?(mconley)
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
|
Assignee | |
Comment 7•12 years ago
|
||
|
||
Comment 8•12 years ago
|
||
Comment on attachment 617896 [details] [diff] [review] change the value to 17em Based on the screenshots, ui-r=me!
Attachment #617896 -
Flags: ui-review?(bwinton) → ui-review+
|
|
||
Comment 9•12 years ago
|
||
Comment on attachment 617896 [details] [diff] [review] change the value to 17em Review of attachment 617896 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thanks Andreas!
Attachment #617896 -
Flags: review?(mconley) → review+
|
|
||
Comment 10•12 years ago
|
||
bump
|
||
Comment 12•12 years ago
|
||
https://hg.mozilla.org/comm-central/rev/9d0f0dd107b1
Assignee: nobody → nisses.mail
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
You need to log in
before you can comment on or make changes to this bug.
Description
•