The attachment part of the preferences pane is very tall

RESOLVED FIXED in Thunderbird 16.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: andreasn, Assigned: andreasn)

Tracking

unspecified
Thunderbird 16.0
x86
Mac OS X
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Compared to the other panes, the attachment pane is very tall.
Note that this is not because of the addition of Filelink, as this happens in the current stable version of Thunderbird as well, even though the content type thing is all empty.
(Assignee)

Comment 1

5 years ago
Richard pointed me to this: http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/preferences/preferences.css#99
(Assignee)

Comment 2

5 years ago
Created attachment 617609 [details] [diff] [review]
changes the value to 15em instead
(Assignee)

Updated

5 years ago
Attachment #617609 - Flags: ui-review?(bwinton)
Attachment #617609 - Flags: review?(mconley)
Andreas:

Hm - this patch seems to cut the bottom of the tabpanel off for me.

See:  http://i.imgur.com/J5cUv.png

-Mike
(Assignee)

Comment 4

5 years ago
(In reply to Mike Conley (:mconley) from comment #3)
> Andreas:
> 
> Hm - this patch seems to cut the bottom of the tabpanel off for me.
> 
> See:  http://i.imgur.com/J5cUv.png

It does for me too. I was blind last night, so I missed that we're supposed to have curves at the bottom.
(Assignee)

Comment 5

5 years ago
Created attachment 617896 [details] [diff] [review]
change the value to 17em

Ehehe, no more cutoffs
Attachment #617609 - Attachment is obsolete: true
Attachment #617609 - Flags: ui-review?(bwinton)
Attachment #617609 - Flags: review?(mconley)
Attachment #617896 - Flags: ui-review?(bwinton)
Attachment #617896 - Flags: review?(mconley)
(Assignee)

Comment 6

5 years ago
Created attachment 617901 [details]
screenshot before
(Assignee)

Comment 7

5 years ago
Created attachment 617902 [details]
screenshot after
Comment on attachment 617896 [details] [diff] [review]
change the value to 17em

Based on the screenshots, ui-r=me!
Attachment #617896 - Flags: ui-review?(bwinton) → ui-review+
Comment on attachment 617896 [details] [diff] [review]
change the value to 17em

Review of attachment 617896 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Thanks Andreas!
Attachment #617896 - Flags: review?(mconley) → review+
bump
(Assignee)

Comment 11

5 years ago
marking for checkin
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/9d0f0dd107b1
Assignee: nobody → nisses.mail
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
You need to log in before you can comment on or make changes to this bug.