748149 - Add a canned version of CNN to talos for tcheck2

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

We're getting a score of almost 1.0 on tcheckerboard/tcheckerboard2 right now. We should switch to CNN from timecube and change the tcheckerboard2 recording more aggressive to drive the score down to around 0.5.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/2) Canned CNN page patch for talos repo

Nothing too interesting here, just adding a cnn folder into talos/startup_test/fennecmark. The main page to be loaded is at cnn/cnn.com/index.html, and all the associated page assets are at cnn/*.com/*, linked to using relative paths from the main page. Using the firebug net panel, I verified that loading this page in desktop Firefox doesn't make any network requests (as opposed to the tp4 canned version, which does).

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/2) WIP - Use CNN for tcheckerboard2 with a more aggressive motion recording

I need the first patch to land before I can test the second one on tbpl, to make sure that the recording is aggressive enough to hit the required score of 0.5.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 617867 [details] [diff] [review]
(1/2) Canned CNN page patch for talos repo

Review of attachment 617867 [details] [diff] [review]:
-----------------------------------------------------------------

not sure if I found everything in here, but these few instances I found look to be hitting external resources.

::: talos/startup_test/fennecmark/cnn/i.cdn.turner.com/cnn/.element/js/3.0/csi_include.js
@@ +5,5 @@
> +	
> +	var idsMatch = (queryId == wId);
> +	
> +	var imageObj = document.createElement('img');
> +	imageObj.setAttribute('src','http://i.cdn.turner.com/cnn/images/1.gif?csiTestMatch='+idsMatch);

hmm, this looks like it will hit external resources.

::: talos/startup_test/fennecmark/cnn/icompass.insightexpressai.com/97.js
@@ +1,1 @@
> +(function(){var PID=97;var RATE=100;function writeTag(p){if((Math.random()*100.0)<RATE){p=typeof(p)=='string'&&p.length?('&'+p):'';document.write(['<script type="text/javascript" language="javascript" src="http://ad.insightexpressai.com/adserver/adServer.aspx?publisherID=',PID,p,'"></', 'script>'].join(''))}};writeTag('');}())
\ No newline at end of file

this looks like it hits external resources.

::: talos/startup_test/fennecmark/cnn/z.cdn.turner.com/cnn/tmpl_asset/static/election-2012-modules/12/js/module-hplib-min.js
@@ +1,1 @@
> +var $j=jQuery;function panelSlider(c){function d(){if(currentPosition==($j("#cnn_panelSlider").width()-viewWidth)){$j("#cnn_panelSlidernext").removeClass("cnn_panelSlidernext");$j("#cnn_panelSlidernext").addClass("cnn_panelSlidernextoff");$j("#cnn_panelSliderprev").removeClass("cnn_panelSliderprevoff");$j("#cnn_panelSliderprev").addClass("cnn_panelSliderprev");}if(currentPosition>0&&currentPosition<($j("#cnn_panelSlider").width()-viewWidth)){$j("#cnn_panelSlidernext").removeClass("cnn_panelSlidernextoff");$j("#cnn_panelSlidernext").addClass("cnn_panelSlidernext");$j("#cnn_panelSliderprev").removeClass("cnn_panelSliderprevoff");$j("#cnn_panelSliderprev").addClass("cnn_panelSliderprev");}if(currentPosition==0){$j("#cnn_panelSliderprev").removeClass("cnn_panelSliderprev");$j("#cnn_panelSliderprev").addClass("cnn_panelSliderprevoff");$j("#cnn_panelSlidernext").removeClass("cnn_panelSlidernextoff");$j("#cnn_panelSlidernext").addClass("cnn_panelSlidernext");}}function a(){if(currentPosition<($j("#cnn_panelSlider").width()-viewWidth)){currentPosition=currentPosition+viewWidth;var e=-currentPosition+"px";$j("#cnn_panelSlider").animate({marginLeft:e},"slow");if(c===false){d();}}}function b(){if(currentPosition>0){currentPosition=currentPosition-viewWidth;var e=-currentPosition+"px";$j("#cnn_panelSlider").animate({marginLeft:e},"slow");if(c===false){d();}}}this.panelNext=a;this.panelPrev=b;this.processNav=d;}var numPanes=0,panelInt="",count=1;$j(document).ready(function(){numPanes=$j(".cnn_panel").length;var a=0,b=0;if(typeof viewWidth!=="undefined"){a=numPanes*viewWidth;b=viewWidth;}$j("#cnn_panelSlider").css("width",a);$j(".cnn_panel").css("width",b);if(numPanes>1){switch(nextDay){case false:$j(".cnn_mpelex12dllrhdr2").append('<div class="cnn_panelSliderarrows">'+'<div class="cnn_panelSlidernext" id="cnn_panelSlidernext" onclick="PS.panelNext();switchState(currentPosition/viewWidth);clearInterval(panelInt);"><img width="31" height="31" alt="Next" src="http://i.cdn.turner.com/cnn/.e/img/3.0/1px.gif"></div>'+'<div class="cnn_panelSliderprevoff" id="cnn_panelSliderprev" onclick="PS.panelPrev();switchState(currentPosition/viewWidth);clearInterval(panelInt);"><img width="31" height="31" alt="Previous" src="http://i.cdn.turner.com/cnn/.e/img/3.0/1px.gif"></div>'+"</div>");break;case true:$j(".cnn_mpelex12dllrhdr2").append('<div class="cnn_panelSliderarrows_sm">'+'<div class="cnn_panelSlidernext" id="cnn_panelSlidernext" onclick="PS.panelNext();switchState(currentPosition/viewWidth);clearInterval(panelInt);"><img width="31" height="21" alt="Next" src="http://i.cdn.turner.com/cnn/.e/img/3.0/1px.gif"></div>'+'<div class="cnn_panelSliderprevoff" id="cnn_panelSliderprev" onclick="PS.panelPrev();switchState(currentPosition/viewWidth);clearInterval(panelInt);"><img width="31" height="21" alt="Previous" src="http://i.cdn.turner.com/cnn/.e/img/3.0/1px.gif"></div>'+"</div>");break;}}if($j("div#cnn_maintoplive").children().hasClass("cnn_tw_border_elections")){$j("div#cnn_maintoplive").height($j("div#cnn_maintoplive").parent().height()+7);$j("div#cnn_maintoplive").addClass("cnn_same_height");$j("div#cnn_maintoplive_border").addClass("cnn_mpelex12bbdr");if($j.browser.msie&&parseInt($j.browser.version,10)===7){$j("div#cnn_maintoplive").height($j("div#cnn_maintoplive").parent().height()+8);$j(".cnn_pad18top").css("padding","0px");}}if(numPanes>1){panelInt=window.setInterval("incrementPanel()",panelIntSec);}});function switchState(b){var a=$j("#hiddenPanel"+b).val();$j(".cnn_mpelex12dllrhdr2 > span").html(a);}function incrementPanel(){PS.panelNext();switchState(currentPosition/viewWidth);count+=1;if(count>numPanes){clearInterval(panelInt);}}
\ No newline at end of file

src="http://i.cdn.turner.com/cnn/.e/img/3.0/1px.gif" <- external access.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

steps for this are to:
1) land the cnn page in the talos repository
2) file a bug to get the bm-remote talos remote webserver farm updated with the latest pagesets
3) land additions to talos.zip to adjust tests to use cnn.com
4) file bug to get new talos.zip on build.m.o and landed in m-c.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

tests don't block

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

ok,I tested with these two patches and the tests work just fine on my local tegra.

We just need to land this on talos and get bug 748619 to update bm-remote.  I can live with the external access if we need this landed tomorrow, and would be happy to look over a patch really early tomorrow morning.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/2) Canned CNN page patch for talos repo

(In reply to Joel Maher (:jmaher) from comment #6)
> ok,I tested with these two patches and the tests work just fine on my local
> tegra.

Do you happen to remember what the score was on the updated test?

> We just need to land this on talos and get bug 748619 to update bm-remote. 
> I can live with the external access if we need this landed tomorrow, and
> would be happy to look over a patch really early tomorrow morning.

So I don't think there's any easy way to guarantee that we're not doing external access at all, but I've loaded that page in Firebug a whole bunch of times and haven't seen any network access. I also updated the page to basically remove every instance of "http" that was in a URL, so hopefully that will eliminate everything. Please land this first patch if you feel it's fine, and go ahead with updating the talos.zip as soon as possible. Once that's in I'll need to run the second patch to make sure tcheckerboard2 is giving low enough scores that we can measure improvement.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 618163 [details] [diff] [review]
(1/2) Canned CNN page patch for talos repo

Review of attachment 618163 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  I was getting between 0.34 and 0.36 on my tegra

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

landed the talos pageset:
http://hg.mozilla.org/build/talos/rev/346576198656

Comment 10

[Kartikaya Gupta (email:[e-mail])]

(In reply to Joel Maher (:jmaher) from comment #8)
> 
> Thanks!  I was getting between 0.34 and 0.36 on my tegra

Oh nice, that's a more aggressive test than I thought it would be. It checkerboarded very little on the galaxy nexus when I created the recording. I'll make it a bit easier then.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Modifying this bug to only track the talos change. I'll file a new bug at the end of the dependency chain to track the robocop update.