748150 - Document contentStyle and contentStyleFile in the tutorials

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect, P1)

Description

[Will Bamberg [:wbamberg]]

Need to update the tutorials to mention contentStyle and contentStyleFile.

Comment 1

[Will Bamberg [:wbamberg]]

Attachment: a patch

Added a couple of notes in the tutorials to introduce contentStyle and contentStyleFile. 

I thought people might expect that tab.attach() would support this option, so I explicitly called out that it doesn't. Maybe it should?

Are these options experimental, do you know?

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 617675 [details] [diff] [review]
a patch

I think it would be a good idea to allow this options in tab.attach, but I don't remember why it's not working in current implementation. There maybe some technical limitations or it's just we have decided to ship what we had and improve in next iterations. ZER0 should now better. I personally don't see any reason why would not we allow these options for tab.attach.

Yes this is experimental for the time being.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/82e9ede44ff1be229061ed80dc88bef95a3c9664
Bug 748150 - Document contentStyle and contentStyleFile in the tutorials;r=gozala

Comment 4

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/3779dc9e8bdba44da62b0947d2d0ed9c36603dc3
Bug 748150 - Document contentStyle and contentStyleFile in the tutorials;r=gozala
(cherry picked from commit 82e9ede44ff1be229061ed80dc88bef95a3c9664)