748208 - Upgrade clang to 155417

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Comment 1

[(no longer active)]

Attachment: Upgrade the compiler revision

Comment 2

[(no longer active)]

My local tests with this revision of clang were successful.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

We normally upgrade linux and os x in lock step. Ping me on IRC if you want help with the spec file or setting up the centos 5 vms.

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 617757 [details] [diff] [review]
Upgrade the compiler revision

Are we going to upgrade to the same revision clang for linux?

Comment 5

[(no longer active)]

Yes.  I'm trying to figure out how to use libtool for this, I'll hopefully have more to say soon.

Comment 6

[Rail Aliiev [:rail]]

I'm going to prep a patch for rpms

Comment 7

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: upgrade clang on linux to 155417

I will start a build in a vm and ping this bug when it is done.

Comment 8

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Comment on attachment 620091 [details] [diff] [review]
upgrade clang on linux to 155417

https://hg.mozilla.org/build/rpm-sources/rev/182c2c7a271b

Comment 9

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Comment on attachment 617757 [details] [diff] [review]
Upgrade the compiler revision

https://hg.mozilla.org/build/braindump/rev/a1605660d9d5

Comment 10

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: puppet change 1: install the new packages

Comment 11

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: puppet change 2: remove the old packages

Comment 12

[Rail Aliiev [:rail]]

Comment on attachment 620115 [details] [diff] [review]
puppet change 2: remove the old packages

Review of attachment 620115 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/packages/manifests/devtools.pp
@@ +110,5 @@
>                  default: {
>                      package {
> +                        "clang_154343_moz0":
> +                            provider  => rpm,
> +                            ensure    => absent;

Can you also add clang-3.0 here? We still have it on some slaves?

Otherwise looks good

Comment 13

[Rail Aliiev [:rail]]

Comment on attachment 620112 [details] [diff] [review]
puppet change 1: install the new packages

lgtm, I'll check it in when we're ready to deploy.

Comment 14

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: puppet change 2: remove the old packages (also remove clang-3.0)

Comment 15

[Rail Aliiev [:rail]]

Comment on attachment 620133 [details] [diff] [review]
puppet change 2: remove the old packages (also remove clang-3.0)

Thanks a lot!

Comment 16

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

The rpm build finished fine on linux64 and the resulting toolchain was able to build  a functional debug and nightly versions of firefox.

Starting a 32 bit build.

Comment 17

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

> Starting a 32 bit build.

32 bit is also OK. Both nightly and debug configurations. Ehsan tested on OS X, so we should be good to go.

Comment 18

[Rail Aliiev [:rail]]

\o/

I'l try to deploy it today/tomorrow.

Comment 19

[Rail Aliiev [:rail]]

Attachment: cleanup source trees

Clean up source directories before checkout. Prevents patch failures.

Comment 20

[Rail Aliiev [:rail]]

Comment on attachment 620305 [details] [diff] [review]
cleanup source trees

http://hg.mozilla.org/build/rpm-sources/rev/bf53f8b8bf68

Comment 21

[Rail Aliiev [:rail]]

Attachment: puppet change 1: install the new packages

This is the same patch, but I moved "clang" ... ensure=> absent section to the top so it removes old package for both linux and linux64. I think, this is why we had disk space issues last time.

Comment 22

[Rail Aliiev [:rail]]

Attachment: puppet change 2: remove the old packages (also remove clang-3.0)

almost the same patch, just moved package names to the "all linux" section.

Comment 23

[Rail Aliiev [:rail]]

Comment on attachment 620389 [details] [diff] [review]
puppet change 1: install the new packages

http://hg.mozilla.org/build/puppet-manifests/rev/9585e09020c1

Comment 24

[Rail Aliiev [:rail]]

Hmm, it turns out that puppet removes clang-3.0-r155417.moz0.dmg somehow... probably pkgdmg provider is too smart. Maybe it uses "clang" from http://hg.mozilla.org/build/braindump/file/a1605660d9d5/mac-related/clang_create_dmg.sh#l28

Comment 25

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

The new package is working. There are one or two oranges we should look at, but it is already better than the previous one.

It is ok to check in the the second puppet change.

Comment 26

[Rail Aliiev [:rail]]

Comment on attachment 620401 [details] [diff] [review]
puppet change 2: remove the old packages (also remove clang-3.0)

http://hg.mozilla.org/build/puppet-manifests/rev/e17e006d4b47