748223 - Pack nsEditor better

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[(no longer active)]

I have a patch which reduces sizeof(nsEditor) from 296 to 280 on 64-bit platforms.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

http://tbpl.mozilla.org/?tree=Try&rev=4f2154cdaebf

Comment 2

[Nicholas Nethercote [inactive]]

How many nsEditor objects are we likely to have live at once?

Comment 3

[Mozilla RelEng Bot]

Try run for 4f2154cdaebf is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=4f2154cdaebf
Results (out of 73 total builds):
    success: 56
    warnings: 7
    failure: 10
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-4f2154cdaebf

Comment 4

[(no longer active)]

(In reply to Nicholas Nethercote [:njn] from comment #2)
> How many nsEditor objects are we likely to have live at once?

Currently, one per textarea element on the page, one per <input type=text> if you've interacted with them (by focusing/typing/etc) or if the page script does some special things (because the nsEditor for those are initialized lazily), one per any text box in XUL documents, and one per HTML document which has an editable section.

Comment 5

[(no longer active)]

https://hg.mozilla.org/projects/birch/rev/3e6ca2158274

Comment 6

[(no longer active)]

And backed out, since we treat warnings as errors!

Comment 7

[(no longer active)]

Relanded: https://hg.mozilla.org/projects/birch/rev/e1f732215854

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/e1f732215854