Closed Bug 748322 Opened 9 years ago Closed 9 years ago

Preffing of the chat feature doesn't disable the gloda IM integration

Categories

(Thunderbird :: Instant Messaging, defect)

defect
Not set
normal

Tracking

(thunderbird13 fixed)

RESOLVED FIXED
Thunderbird 14.0
Tracking Status
thunderbird13 --- fixed

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
I've noticed while preparing the patch to disable IM in Thunderbird 13 beta that flipping the value of the pref doesn't disable completely the integration of IM in gloda: IM results will never be displayed, but we will still create the SQLite tables for IM and attempt to index IM conversations at startup (there will likely be none).

This doesn't seem like the right behavior, as I would prefer not touching the profile at all when IM isn't enabled.

Depending on how you (Mark, David?) feel about this, we may want to land the trivial attached patch in comm-central and comm-aurora before the merge, or in comm-beta at the same time as the patch to disable IM for Tb13beta. I requested review from both of you, but I don't think this needs both, just whoever reads it first.
Attachment #617845 - Flags: review?(mbanner)
Attachment #617845 - Flags: review?(dbienvenu)
Attachment #617845 - Flags: approval-comm-aurora?
Attachment #617845 - Flags: review?(dbienvenu) → review+
Comment on attachment 617845 [details] [diff] [review]
Patch

a=me as we'll want this for beta.
Attachment #617845 - Flags: review?(mbanner)
Attachment #617845 - Flags: approval-comm-aurora?
Attachment #617845 - Flags: approval-comm-aurora+
Thanks for the quick review and approval!

http://hg.mozilla.org/comm-central/rev/7d36cb752e09
http://hg.mozilla.org/releases/comm-aurora/rev/4b19ab70a494
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.