Preffing of the chat feature doesn't disable the gloda IM integration

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Thunderbird 14.0

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(1 attachment)

Created attachment 617845 [details] [diff] [review]
Patch

I've noticed while preparing the patch to disable IM in Thunderbird 13 beta that flipping the value of the pref doesn't disable completely the integration of IM in gloda: IM results will never be displayed, but we will still create the SQLite tables for IM and attempt to index IM conversations at startup (there will likely be none).

This doesn't seem like the right behavior, as I would prefer not touching the profile at all when IM isn't enabled.

Depending on how you (Mark, David?) feel about this, we may want to land the trivial attached patch in comm-central and comm-aurora before the merge, or in comm-beta at the same time as the patch to disable IM for Tb13beta. I requested review from both of you, but I don't think this needs both, just whoever reads it first.
Attachment #617845 - Flags: review?(mbanner)
Attachment #617845 - Flags: review?(dbienvenu)
Attachment #617845 - Flags: approval-comm-aurora?

Updated

5 years ago
Attachment #617845 - Flags: review?(dbienvenu) → review+
Comment on attachment 617845 [details] [diff] [review]
Patch

a=me as we'll want this for beta.
Attachment #617845 - Flags: review?(mbanner)
Attachment #617845 - Flags: approval-comm-aurora?
Attachment #617845 - Flags: approval-comm-aurora+
Thanks for the quick review and approval!

http://hg.mozilla.org/comm-central/rev/7d36cb752e09
http://hg.mozilla.org/releases/comm-aurora/rev/4b19ab70a494
Assignee: nobody → florian
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-thunderbird13: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.