Last Comment Bug 748322 - Preffing of the chat feature doesn't disable the gloda IM integration
: Preffing of the chat feature doesn't disable the gloda IM integration
Product: Thunderbird
Classification: Client Software
Component: Instant Messaging (show other bugs)
: Trunk
: All All
-- normal (vote)
: Thunderbird 14.0
Assigned To: Florian Quèze [:florian] [:flo]
Depends on:
  Show dependency treegraph
Reported: 2012-04-24 06:00 PDT by Florian Quèze [:florian] [:flo]
Modified: 2012-04-24 07:37 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Patch (1.63 KB, patch)
2012-04-24 06:00 PDT, Florian Quèze [:florian] [:flo]
mozilla: review+
standard8: approval‑comm‑aurora+
Details | Diff | Splinter Review

Description User image Florian Quèze [:florian] [:flo] 2012-04-24 06:00:32 PDT
Created attachment 617845 [details] [diff] [review]

I've noticed while preparing the patch to disable IM in Thunderbird 13 beta that flipping the value of the pref doesn't disable completely the integration of IM in gloda: IM results will never be displayed, but we will still create the SQLite tables for IM and attempt to index IM conversations at startup (there will likely be none).

This doesn't seem like the right behavior, as I would prefer not touching the profile at all when IM isn't enabled.

Depending on how you (Mark, David?) feel about this, we may want to land the trivial attached patch in comm-central and comm-aurora before the merge, or in comm-beta at the same time as the patch to disable IM for Tb13beta. I requested review from both of you, but I don't think this needs both, just whoever reads it first.
Comment 1 User image Mark Banner (:standard8) 2012-04-24 07:30:23 PDT
Comment on attachment 617845 [details] [diff] [review]

a=me as we'll want this for beta.
Comment 2 User image Florian Quèze [:florian] [:flo] 2012-04-24 07:37:07 PDT
Thanks for the quick review and approval!

Note You need to log in before you can comment on or make changes to this bug.