748342 - exception in db after syncing and attempting to store favicons

Status: RESOLVED DUPLICATE of bug 717428

(Firefox for Android Graveyard :: General, defect)

Description

[Tony Chung [:tchung]]

Db Execption is thrown when syncing from desktop and launching site on fennec.    I've encountered this before in https://bugzilla.mozilla.org/show_bug.cgi?id=731443#c3.

Repro:
1) Tested against rnewman's private build, 4-24-2012.
2) launch desktop firefox, create a new sync account, save a bookmark or two
3) pair on fennec, and watch logs during sync
4) when sync has finished, open up bookmarks and go to sync'd data.   launch one of your bookmarks
5) Verify favicon exception.

04-24 09:46:10.431: DEBUG/GeckoFavicons(11830): Downloaded favicon successfully for URL = https://bugzilla.mozilla.org/show_bug.cgi?id=723053
04-24 09:46:10.461: DEBUG/GeckoFavicons(11830): Saving favicon on browser database for URL = https://bugzilla.mozilla.org/show_bug.cgi?id=723053
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830): exception in DB operation
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830): android.database.sqlite.SQLiteConstraintException: error code 19: constraint failed
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at android.database.sqlite.SQLiteStatement.native_execute(Native Method)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at android.database.sqlite.SQLiteStatement.execute(SQLiteStatement.java:61)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at android.database.sqlite.SQLiteDatabase.insertWithOnConflict(SQLiteDatabase.java:1671)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at android.database.sqlite.SQLiteDatabase.insertOrThrow(SQLiteDatabase.java:1541)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at org.mozilla.fennec_rnewman.db.BrowserProvider.insertInTransaction(BrowserProvider.java:1323)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at org.mozilla.fennec_rnewman.db.BrowserProvider.insert(BrowserProvider.java:1243)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at android.content.ContentProvider$Transport.insert(ContentProvider.java:210)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at android.content.ContentResolver.insert(ContentResolver.java:606)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at org.mozilla.gecko.db.LocalBrowserDB.updateFaviconForUrl(LocalBrowserDB.java:558)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at org.mozilla.gecko.db.BrowserDB.updateFaviconForUrl(BrowserDB.java:180)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at org.mozilla.gecko.Favicons$LoadFaviconTask.saveFaviconToDb(Favicons.java:266)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:354)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:227)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at android.os.AsyncTask$2.call(AsyncTask.java:185)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:306)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at java.util.concurrent.FutureTask.run(FutureTask.java:138)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1088)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:581)
04-24 09:46:10.521: ERROR/GeckoBrowserProvider(11830):     at java.lang.Thread.run(Thread.java:1027)
04-24 09:46:10.521: DEBUG/GeckoFavicons(11830): Saving favicon URL for URL = https://bugzilla.mozilla.org/show_bug.cgi?id=723053
04-24 09:46:10.521: DEBUG/GeckoFavicons(11830): Calling setFaviconUrlForPageUrl() for https://bugzilla.mozilla.org/show_bug.cgi?id=723053
04-24 09:46:10.561: DEBUG/GeckoFavicons(11830): LoadFaviconTask finished for URL = https://bugzilla.mozilla.org/show_bug.cgi?id=723053 (4)
04-24 09:46:10.561: INFO/GeckoApp(11830): Favicon successfully loaded for URL = https://bugzilla.mozilla.org/show_bug.cgi?id=723053
04-24 09:46:10.561: INFO/GeckoApp(11830): Favicon is for current URL = https://bugzilla.mozilla.org/show_bug.cgi?id=723053
04-24 09:46:10.561: INFO/GeckoTab(11830): Updated favicon for tab with id: 1


Expected:
- no favicon db exception

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

noming just in case...

Comment 2

[Richard Newman [:rnewman]]

This happens routinely, in my experience. gcp, do you remember the schema change bug that would address this?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Dependent on bug 717428 ?

Comment 4

[Gian-Carlo Pascutto [:gcp]]

The favicon schema issue is Bug 717428. If this is just a warning (not a crash), then dupe this bug against it.