Closed
Bug 748344
Opened 12 years ago
Closed 12 years ago
xplat: use something other than AVM for reference avmshell (used for e.g. tracer generation)
Categories
(Tamarin Graveyard :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pnkfelix, Assigned: pnkfelix)
References
Details
Attachments
(1 file, 1 obsolete file)
2.72 KB,
patch
|
brbaker
:
review+
|
Details | Diff | Splinter Review |
Bug 632857, comment 19, put in a change that was a slight change to our old semantics if you ran an xplat make in a context where the AVM environment variable is defined. Ingo has been running into problems with that, since he had set AVM to some value for separate testing and his build was failing. He recommended that we either (or both): * Use a different environment variable (I am currently thinking AVMSHELL_TOOL) so that we do not introduce a new interpretation for AVM in the xplat build. * Issue a message when we do the tracer generation that explicitly relates its running to the presence of the environment variable, so that someone who is trying to understand the build output has a better chance of understanding what has gone wrong.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → fklockii
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
(aesthetic fix to make similarity of both rules more explicit)
Attachment #617861 -
Attachment is obsolete: true
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 617863 [details] [diff] [review] patch A v2: fix it! R? (I had been skipping code-reviews on a lot of my xplat revisions lately; but maybe the problems Ingo encountered would have been addressed earlier if I had followed the process properly. So I am trying to make good on that now.)
Attachment #617863 -
Flags: review?(brbaker)
Updated•12 years ago
|
Attachment #617863 -
Flags: review?(brbaker) → review+
Comment 4•12 years ago
|
||
changeset: 7371:c8e201cf8268 user: Felix Klock II <fklockii@adobe.com> summary: Bug 748344: [xplat] dont overload AVM; use AVMSHELL_TOOL env var for tracer-gen (r=brbaker). http://hg.mozilla.org/tamarin-redux/rev/c8e201cf8268
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 5•12 years ago
|
||
changeset: 7379:9ef7bb33fc2f user: Felix Klock II <fklockii@adobe.com> summary: Bug 748344: [xplat] fix syntactic mistake in previous patch (r=fklockii). http://hg.mozilla.org/tamarin-redux/rev/9ef7bb33fc2f
You need to log in
before you can comment on or make changes to this bug.
Description
•