748428 - Non-existent branches need to be properly handled

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Marc Jessome[:mjessome]]

Attachment: Fix branch handling v1

When autoland is flagged for a branch that does not exist, the permissions API (which checks permissions on hg repos) will return None. We want to use this as an indication that it is an invalid branch, and fail out with an appropriate comment back to the user.

This also takes care of some small mistakes that were made with "branch" variable usage.

Comment 1

[Rail Aliiev [:rail]]

Comment on attachment 617927 [details] [diff] [review]
Fix branch handling v1

Waiting for v2...

Comment 2

[Marc Jessome[:mjessome]]

Attachment: Fix branch handling v2

Version 2, using an Exception rather than a common return value.

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 617958 [details] [diff] [review]
Fix branch handling v2

Review of attachment 617958 [details] [diff] [review]:
-----------------------------------------------------------------

::: autoland_queue.py
@@ +690,5 @@
> +    try:
> +        branch_perms = ldap.get_branch_permissions(branch.name)
> +    except ldap_utils.BranchDoesNotExist:
> +        post_comment("Autoland Failure:\n"
> +                     "Cannot land to branch %s."

A nit: add \n here.