748610 - [SeaMonkey, 2.10+] "Error: package error or possible missing or unnecessary file: bin/distribution/extensions/[e-mail]"

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[Serge Gautherie (:sgautherie)]

SeaMonkey Beta-2.10:
{
Error: package error or possible missing or unnecessary file: bin/distribution/extensions/[e-mail] (package-manifest, 546).
}

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Package SeaMonkey debugQA extension on Alpha builds only

(Untested.)

[Approval Request Comment]
"No" risk, buildtime only.

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 618112 [details] [diff] [review]
(Av1) Package SeaMonkey debugQA extension on Alpha builds only

>diff --git a/suite/installer/Makefile.in b/suite/installer/Makefile.in
>+ifdef IS_ALPHA
>+DEFINES += -DMOZ_IS_ALPHA=1
>+endif

I don't feel comfortable pushing this logic up to configure, and would rather just use this define with

ifneq (,$(findstring a,$(MOZ_APP_VERSION:pre=a)))

Comment 3

[Serge Gautherie (:sgautherie)]

Ftr, the extension should not be removed(-files.in), per

https://wiki.mozilla.org/SeaMonkey:Debug_And_QA_UI
"For release builds you can install extension from AMO."

*****

(In reply to Justin Wood (:Callek) from comment #2)

> I don't feel comfortable pushing this logic up to configure,

Why? It would seem logical to reuse a unique definition.

> and would rather just use this define with
> 
> ifneq (,$(findstring a,$(MOZ_APP_VERSION:pre=a)))

In that case, shouldn't we drop 'pre' handling, which is obsolete (isn't it)?
Handling MOZ_APP_VERSION in two different ways seems odd (currently).

Comment 4

[Justin Wood (:Callek)]

(In reply to Serge Gautherie (:sgautherie) from comment #3)
> Ftr, the extension should not be removed(-files.in), per
> 
> https://wiki.mozilla.org/SeaMonkey:Debug_And_QA_UI
> "For release builds you can install extension from AMO."
> 
> *****
> 
> (In reply to Justin Wood (:Callek) from comment #2)
> 
> > I don't feel comfortable pushing this logic up to configure,
> 
> Why? It would seem logical to reuse a unique definition.

To me, custom logic based on version for SeaMonkey only belongs under suite/ at the least. And because of that I don't think we want/need a configure piece of magic here just for this.

> > and would rather just use this define with
> > 
> > ifneq (,$(findstring a,$(MOZ_APP_VERSION:pre=a)))
> 
> In that case, shouldn't we drop 'pre' handling, which is obsolete (isn't it)?
> Handling MOZ_APP_VERSION in two different ways seems odd (currently).

IMO, using pre *might* still have legit reasons in the future... so I'd rather keep that working since it doesn't hurt anything

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) Package SeaMonkey debugQA extension on Alpha (or Nightly) builds only [Checked in: Comments 6 and 8]

Av1, with comment 4 suggestion(s).

I am not fully convinced, but that doesn't matter much ftb.

[Approval Request Comment]
Blocker bustage fix.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 619954 [details] [diff] [review]
(Av2) Package SeaMonkey debugQA extension on Alpha (or Nightly) builds only
[Checked in: Comments 6 and 8]

http://hg.mozilla.org/comm-central/rev/4df6a3ad8bc6

Comment 7

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1335917741.1335928891.23436.gz&fulltext=1
WINNT 5.2 comm-central-trunk build on 2012/05/01 17:15:41
{
-DMOZ_PACKAGE_DEBUGQA=1

[debugqa]
bin/distribution/extensions/[e-mail]
}

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 619954 [details] [diff] [review]
(Av2) Package SeaMonkey debugQA extension on Alpha (or Nightly) builds only
[Checked in: Comments 6 and 8]

http://hg.mozilla.org/releases/comm-aurora/rev/2c595fb63995
http://hg.mozilla.org/releases/comm-beta/rev/6c022d9e7c65

Comment 9

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1336009132.1336013775.25771.gz&fulltext=1
WINNT 5.2 comm-beta build on 2012/05/02 18:38:52
{
[debugqa]
/bin/sh {...}
}

V.Fixed.
seamonkey2.11 and seamonkey2.10: verified.