Please make TBPLbot comments collapsed by default

RESOLVED FIXED

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ehsan, Assigned: glob)

Tracking

Production

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
This makes those bugs a lot easier to navigate.  We should also change the existing Collapse link to make it Expand those comments.
(Assignee)

Updated

7 years ago
Assignee: nobody → glob
(Assignee)

Comment 1

7 years ago
Created attachment 618587 [details] [diff] [review]
patch v1

this adds a new hook so we can collapse the comments as they are rendered, instead of waiting for dom to load then collapsing the comments.
Attachment #618587 - Flags: review?(dkl)
(Reporter)

Comment 2

7 years ago
Thanks for doing this, Byron.  :-)
Comment on attachment 618587 [details] [diff] [review]
patch v1

Review of attachment 618587 [details] [diff] [review]:
-----------------------------------------------------------------

The changes work as expected and code-wise looks fine. r=dkl

::: template/en/default/bug/comments.html.tmpl
@@ +216,4 @@
>    [%- comment_text FILTER quoteUrls(bug, comment) -%]
>  </pre>
>      </div>
> +    [% Hook.process('end', 'bug/comments.html.tmpl') %]

I would prefer 'comment_end' as simply 'end' makes the ext template bug/comments-end.html.tmpl which makes me think the end of the comments.html.tmpl template and not the end of an individual comment in [% BLOCK a_comment %]. I know we have 'after_comments' already for that purpose but confusing none-the-less. I leave it to your discretion.
Attachment #618587 - Flags: review?(dkl) → review+
(Assignee)

Comment 4

7 years ago
(In reply to David Lawrence [:dkl] from comment #3)
> I would prefer 'comment_end' as simply 'end' makes the ext template
> bug/comments-end.html.tmpl which makes me think the end of the
> comments.html.tmpl template and not the end of an individual comment in [%
> BLOCK a_comment %].

good point.  i went with comments-a_comment-end to reflect the name of the block which contains the hook.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/
added extensions/BMO/template/en/default/hook/bug/comments-a_comment-end.html.tmpl
modified extensions/BMO/template/en/default/hook/bug/comments-aftercomments.html.tmpl
deleted extensions/BMO/template/en/default/hook/bug/comments-user.html.tmpl
modified extensions/BMO/template/en/default/hook/bug/comments-user.html.tmpl
modified template/en/default/bug/comments.html.tmpl
Committed revision 8166.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
added extensions/BMO/template/en/default/hook/bug/comments-a_comment-end.html.tmpl
modified extensions/BMO/template/en/default/hook/bug/comments-aftercomments.html.tmpl
deleted extensions/BMO/template/en/default/hook/bug/comments-user.html.tmpl
modified template/en/default/bug/comments.html.tmpl
Committed revision 8147.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(In reply to Byron Jones ‹:glob› from comment #4)
> good point.  i went with comments-a_comment-end to reflect the name of the
> block which contains the hook.

Cool. One nit would have been to call it a_comment_end instead as we normally do not see hook names with '-' any more but no matter.

dkl
You need to log in before you can comment on or make changes to this bug.