74865 - [DUP?]radio buttons and checkboxes not properly aligned with text

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P2)

Description

[Leston Buell]

Text appears too low next to a radio button or checkbox. View the attached test
case and compare the alignment between Mozilla and Netscape 4.

Comment 1

[Leston Buell]

Attachment: test case html page

Comment 2

[Andreas M. "Clarence" Schneider]

I see this with 2001-04-09-04, Win NT, and found no other bug for it.
Confirming. OS -> all.

Comment 3

[rods (gone)]

This may be a dup, I have seen something to do with this

Comment 4

[Marc Attinasi]

I had this same bug and Hyatt told me he was planning on fixing it for 0.9.2 (ot
thereabouts). I couldn't find it just now though... I'll ping him again, it is ugly.

Comment 5

[Blake Ross]

Well, Rod is gone, doesn't look like we're getting a fix for this by tomorrow
night. Pushing out...

marc, did you ever ping hyatt about this?

Comment 6

[Marc Attinasi]

Yes, Hyatt could not remember it, and I could not find the other bug. I dug into
it a bit and remembered the fix: in forms.css the vertical-align property for
radio buttons and checkboxes is 'baseline'. If I change it to 'bottom' it lines
up correctly. I'm attaching a testcase that changes the property to show how it
corrects the problem, but the change needs to be made to forms.css

Comment 7

[Marc Attinasi]

Attachment: testcase with vertical-align: bottom style rule (overriding the vertical-align: baseline from forms.css)

Comment 8

[Hixie (not reading bugmail)]

dbaron will probably have things to say about that idea... :-)

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

vertical-align: bottom is wrong.  See bug 87981.  You *may* want text-bottom
(although probably not), but not bottom.  What we *really* want is to do
baseline alignment correctly.

Comment 10

[Marc Attinasi]

Oh yea, bug 87981 - now I remember :) 

Of course, you are right dbaron. vertical-align: bottom is worse than
vertical-align: text-bottom (and either is better than the mess we make of
vertical-align: baseline on the branch).

Marking this bug depends-on bug 87981 since fixing that problem makes the radios
and checkboxes align better.)

Comment 11

[rods (gone)]

this is now fixed by checkin to Bug 91602

Comment 12

[Madhur Bhatia]

The radio buttons align correctly, now.
Verified fixed on window2000 - buildID: 2001-08-22-06trunk