Closed Bug 748684 Opened 7 years ago Closed 7 years ago

GCLI shouldn't require removeCommand before addCommand

Categories

(DevTools :: Console, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file)

Right now GCLI gets cross with you if you call addCommand twice with the same (or maybe updated) command spec. Calling addCommand a second time with a command with a given name should replace the original command cleanly (perhaps with a suitable warning)
Attached patch Upload 1Splinter Review
a.k.a https://github.com/campd/gcli/pull/35
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #623134 - Flags: review?(dcamp)
Attachment #623134 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/mozilla-central/rev/cb193fb4d45a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.