GCLI shouldn't require removeCommand before addCommand

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Console
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

Trunk
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment)

Right now GCLI gets cross with you if you call addCommand twice with the same (or maybe updated) command spec. Calling addCommand a second time with a command with a given name should replace the original command cleanly (perhaps with a suitable warning)
Blocks: 745773
Created attachment 623134 [details] [diff] [review]
Upload 1

a.k.a https://github.com/campd/gcli/pull/35
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #623134 - Flags: review?(dcamp)
Relevant tries:
https://tbpl.mozilla.org/?tree=Try&rev=27b9b61a663e
https://tbpl.mozilla.org/?tree=Try&rev=77b47c8bbc35
https://tbpl.mozilla.org/?tree=Try&rev=1ce36097dc58

Updated

5 years ago
Attachment #623134 - Flags: review?(dcamp) → review+
Try before land:
https://tbpl.mozilla.org/?tree=Try&rev=eba127ab7962

Fx-Team:
https://tbpl.mozilla.org/?tree=Fx-Team&rev=0f08ab4dfcac
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/cb193fb4d45a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.