Make transformiix |#include|s better

VERIFIED FIXED in mozilla0.9

Status

()

P2
trivial
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: axel, Assigned: axel)

Tracking

Trunk
mozilla0.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

18 years ago
The transformiix source has alot of #includes in header files, and quite alot
headers include other files before checking the #ifndef.
This causes us grief in compile performance, so clear it up.
I'll remove MITREObject in the run, it's just an alias for TxObject, 
MITREObjectWrapper is now TxObjectWrapper.
Removing the String version history comments as well.

Patch tested on solaris standalone and mozmodule, I'd need some mac and windows
love.
add the TxObjectWrapper.cpp to source/base.

The releases.txt comment in the string files disappeared, 'cause we don't have 
that file.

Axel
(Assignee)

Comment 1

18 years ago
Created attachment 29828 [details] [diff] [review]
moving #includes in extensions/transformiix
(Assignee)

Comment 2

18 years ago
Created attachment 29829 [details]
TxObjectWrapper.cpp, this is the slightly modified MITREObjectWrapper.cpp
(Assignee)

Comment 3

18 years ago
hrm. we don't have target milestone tomorrow :-(
Status: NEW → ASSIGNED
Keywords: review
r=peterv@netscape.com, look for an sr.
I have an updated Mac project file (removed MITREObjectWrapper.cpp, added
TxObjectWrapper.cpp). Let me know when you check this in, so that I can check in
the project file. If no one else does, I'll do the Windows makefiles too.
Thanks for doing this Axel.
Severity: normal → trivial
Priority: -- → P2
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 5

18 years ago
adding scc for sr, the patch has windows makefiles, too, can someone test this?
peterv? sicking?

Axel

Comment 6

18 years ago
sr=scc
Tested on windows and checked in. I've removed the invalid e-mail addresses, no
need to leave them in if we know they're wrong. If we find out what their new
addresses are, we'll add those.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

18 years ago
playing nice, verifying.
Status: RESOLVED → VERIFIED
Keywords: review
You need to log in before you can comment on or make changes to this bug.