Closed
Bug 74873
Opened 24 years ago
Closed 24 years ago
Make transformiix |#include|s better
Categories
(Core :: XSLT, defect, P2)
Core
XSLT
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: axel, Assigned: axel)
Details
Attachments
(2 files)
|
59.89 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.25 KB,
text/plain
|
Details |
The transformiix source has alot of #includes in header files, and quite alot
headers include other files before checking the #ifndef.
This causes us grief in compile performance, so clear it up.
I'll remove MITREObject in the run, it's just an alias for TxObject,
MITREObjectWrapper is now TxObjectWrapper.
Removing the String version history comments as well.
Patch tested on solaris standalone and mozmodule, I'd need some mac and windows
love.
add the TxObjectWrapper.cpp to source/base.
The releases.txt comment in the string files disappeared, 'cause we don't have
that file.
Axel
| Assignee | ||
Comment 1•24 years ago
|
||
| Assignee | ||
Comment 2•24 years ago
|
||
| Assignee | ||
Comment 3•24 years ago
|
||
hrm. we don't have target milestone tomorrow :-(
Status: NEW → ASSIGNED
Keywords: review
Comment 4•24 years ago
|
||
r=peterv@netscape.com, look for an sr.
I have an updated Mac project file (removed MITREObjectWrapper.cpp, added
TxObjectWrapper.cpp). Let me know when you check this in, so that I can check in
the project file. If no one else does, I'll do the Windows makefiles too.
Thanks for doing this Axel.
Severity: normal → trivial
Priority: -- → P2
Target Milestone: --- → mozilla0.9
| Assignee | ||
Comment 5•24 years ago
|
||
adding scc for sr, the patch has windows makefiles, too, can someone test this?
peterv? sicking?
Axel
Comment 6•24 years ago
|
||
sr=scc
Comment 7•24 years ago
|
||
Tested on windows and checked in. I've removed the invalid e-mail addresses, no
need to leave them in if we know they're wrong. If we find out what their new
addresses are, we'll add those.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 8•24 years ago
|
||
playing nice, verifying.
Status: RESOLVED → VERIFIED
Keywords: review
You need to log in
before you can comment on or make changes to this bug.
Description
•