748753 - ESR 10.0.3 and 10.0.4 issue with nsIDOMHTMLDocument reference

Status: RESOLVED INCOMPLETE

(Core :: DOM: Core & HTML, defect)

Description

[Srini]

User Agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.162 Safari/535.19

Steps to reproduce:

I have an add-on for Firefox browser which uses native XPCOM APIS for getting some screen related bounds/hierarchy. The extension is giving wrong results with latest ESR 10.0.3. Issue is, I have nsidomDocument reference which I convert it to nsIDOMHTMLDocument reference, which worked fine till 10.0.2 but with 10.0.3 and 10.0.4  it is causing failure as  "htmlDocument" in following code returns null.  nsIDOMHTMLDocumentPtr htmlDocument = do_QueryInterface(domDocument) ;
I tried searching in forums for the change which caused this post 10.0.2, could not find any information.


Actual results:

Reference coming null, which is resulting in wrong domdocument reference.


Expected results:

Non null return value is expected. Or I would like to know any other way to achieve same.

Comment 1

[Matthias Versen [:Matti]]

Is this only an issue on the ESR branch ?

Comment 2

[Mats Palmgren (inactive)]

Pushlog for 10.0.2 -> 10.0.3:
http://hg.mozilla.org/releases/mozilla-esr10/pushloghtml?fromchange=FIREFOX_10_0_2esr_RELEASE&tochange=FIREFOX_10_0_3esr_RELEASE

Comment 3

[Mats Palmgren (inactive)]

Srini, is domDocument also null?  if so, where did you get it from?

Comment 4

[Srini]

Hi Mats,
domDocument  is not null.
I have nsIDOMWindow reference say window, I use following to get domDocument.
window->GetDocument(getter_AddRefs(domDocument);

Comment 5

[Srini]

>>>Is this only an issue on the ESR branch ?
I did not see this issue on Firefox 8.0 and below and on ESR branch also till 10.0.2 this issue is not seen.

Is there any gecko SDK planned for intermediate fixpacks on ESR branch?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

So, domDocument isn't null. What kind of document is it, if it is not HTMLDocument?
Is it nsIDOMXULDocument? nsIDOMXMLDocument?

Note, in general
nsCOMPtr<nsIDOMDocument> domDocument;
window->GetDocument(getter_AddRefs(domDocument);
nsCOMPtr<nsIDOMHTMLDocument> htmlDocument = do_QueryInterface(domDocument);
may end up null htmlDocument, but non-null domDocument, since not all documents are
html documents.

Comment 7

[Mats Palmgren (inactive)]

Why did it change between 10.0.2 -> 10.0.3 though?  (see comment 2 for pushlog)

Comment 8

[Boris Zbarsky [:bzbarsky]]

I looked at the diff between those two release tags.  The only IDL change was to content/base/public/nsIDroppedLinkHandler.idl (why did we do that on ESR???).  There were no other changes to content/base/public, and the only content/base/src changes were changes to the CSP tokenizer and the fullscreen internal APIs.

So nothing there should have caused any changes when QIing the document per se.

We do have ESR nightlies, looks like.  Srini, would you be willing to use those to narrow down when the problem first appears for you?

Comment 9

[Mats Palmgren (inactive)]

Srini, it would help a lot if you can find the first build where the problem occurs
in the *-esr10 or *-esr10-debug builds here:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2012/02/
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2012/03/

Comment 10

[Srini]

In released Gecko SDKs I find 10.0.2 but not 10.0.3 or 10.0.4.
Are you releasing gecko SDK for all ESR versions?

Comment 11

[Michelle Funches - QA]

This bug has been tagged for Regression and or Closure.
@Reporter, is this still an issue? If yes, can you please state your current operating system and Fx version and STR.

Comment 12

[Michelle Funches - QA]

Closing as Incomplete:
Feel free to reopen the bug if the issue still reproduces on a current build.
Please provide detailed Steps, Operating System and Firefox version.