Account Setup Wizard loaded on every startup

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Account Manager
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenB, Assigned: Magnus Melin)

Tracking

({footprint, perf, regression})

Trunk
Thunderbird 15.0
footprint, perf, regression
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Reproduction:
* Enable log4moz logging for module "mail.wizard"
* Start Thunderbird (with accounts already set up)

Actual result:
Immediately after startup:
2012-04-25 18:36:00     mail.wizard     INFO    Initializing setup wizard
2012-04-25 18:36:00     mail.wizard     INFO    email account setup dialog
=> JS code of the wizard is loaded
No account wizard shows up

Expected result:
No account wizard shows up
The above log messages don't show
No JS code of the wizard is loaded

Impact:
Useless processing, slows startup, pointless.
(Reporter)

Updated

5 years ago
Keywords: regression

Updated

5 years ago
Keywords: footprint, perf

Comment 1

5 years ago
Which exact TB version is this about? Could you please set the "Version" field acordingly?
(Reporter)

Updated

5 years ago
Version: unspecified → Trunk
(Assignee)

Comment 2

5 years ago
Created attachment 619424 [details] [diff] [review]
proposed fix

This should do it, but i'm not really sure when this code executes in practice. I just moved the loading to where it's needed which seems like in very special cases.

On this machine we win 35ms in startup time.
Assignee: bwinton → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #619424 - Flags: review?(bwinton)
(Assignee)

Comment 3

5 years ago
From bug 686347.
Blocks: 686347
(Assignee)

Updated

5 years ago
Severity: minor → normal
OS: Linux → All
Hardware: x86_64 → All
(Reporter)

Comment 4

5 years ago
Comment on attachment 619424 [details] [diff] [review]
proposed fix

Patch looks good, thanks.
Attachment #619424 - Flags: feedback+
Comment on attachment 619424 [details] [diff] [review]
proposed fix

Looks good, and all the tests seem to pass, and quicker startup is never a bad thing.  :)

r=me!

Thanks,
Blake.
Attachment #619424 - Flags: review?(bwinton) → review+
(Assignee)

Comment 6

5 years ago
http://hg.mozilla.org/comm-central/rev/363f59461e36
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.