Last Comment Bug 748830 - Account Setup Wizard loaded on every startup
: Account Setup Wizard loaded on every startup
Status: RESOLVED FIXED
: footprint, perf, regression
Product: Thunderbird
Classification: Client Software
Component: Account Manager (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 15.0
Assigned To: Magnus Melin
:
:
Mentors:
Depends on:
Blocks: 686347
  Show dependency treegraph
 
Reported: 2012-04-25 09:41 PDT by Ben Bucksch (:BenB)
Modified: 2012-05-09 11:33 PDT (History)
3 users (show)
mkmelin+mozilla: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
proposed fix (6.17 KB, patch)
2012-04-29 10:57 PDT, Magnus Melin
bwinton: review+
ben.bucksch: feedback+
Details | Diff | Splinter Review

Description Ben Bucksch (:BenB) 2012-04-25 09:41:42 PDT
Reproduction:
* Enable log4moz logging for module "mail.wizard"
* Start Thunderbird (with accounts already set up)

Actual result:
Immediately after startup:
2012-04-25 18:36:00     mail.wizard     INFO    Initializing setup wizard
2012-04-25 18:36:00     mail.wizard     INFO    email account setup dialog
=> JS code of the wizard is loaded
No account wizard shows up

Expected result:
No account wizard shows up
The above log messages don't show
No JS code of the wizard is loaded

Impact:
Useless processing, slows startup, pointless.
Comment 1 Andre Klapper 2012-04-27 17:45:35 PDT
Which exact TB version is this about? Could you please set the "Version" field acordingly?
Comment 2 Magnus Melin 2012-04-29 10:57:23 PDT
Created attachment 619424 [details] [diff] [review]
proposed fix

This should do it, but i'm not really sure when this code executes in practice. I just moved the loading to where it's needed which seems like in very special cases.

On this machine we win 35ms in startup time.
Comment 3 Magnus Melin 2012-04-29 11:01:17 PDT
From bug 686347.
Comment 4 Ben Bucksch (:BenB) 2012-04-29 12:59:14 PDT
Comment on attachment 619424 [details] [diff] [review]
proposed fix

Patch looks good, thanks.
Comment 5 Blake Winton (:bwinton) (:☕️) 2012-05-01 07:11:54 PDT
Comment on attachment 619424 [details] [diff] [review]
proposed fix

Looks good, and all the tests seem to pass, and quicker startup is never a bad thing.  :)

r=me!

Thanks,
Blake.

Note You need to log in before you can comment on or make changes to this bug.