748830 - Account Setup Wizard loaded on every startup

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Ben Bucksch (:BenB)]

Reproduction:
* Enable log4moz logging for module "mail.wizard"
* Start Thunderbird (with accounts already set up)

Actual result:
Immediately after startup:
2012-04-25 18:36:00     mail.wizard     INFO    Initializing setup wizard
2012-04-25 18:36:00     mail.wizard     INFO    email account setup dialog
=> JS code of the wizard is loaded
No account wizard shows up

Expected result:
No account wizard shows up
The above log messages don't show
No JS code of the wizard is loaded

Impact:
Useless processing, slows startup, pointless.

Comment 1

[Andre Klapper]

Which exact TB version is this about? Could you please set the "Version" field acordingly?

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

This should do it, but i'm not really sure when this code executes in practice. I just moved the loading to where it's needed which seems like in very special cases.

On this machine we win 35ms in startup time.

Comment 3

[Magnus Melin [:mkmelin]]

From bug 686347.

Comment 4

[Ben Bucksch (:BenB)]

Comment on attachment 619424 [details] [diff] [review]
proposed fix

Patch looks good, thanks.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 619424 [details] [diff] [review]
proposed fix

Looks good, and all the tests seem to pass, and quicker startup is never a bad thing.  :)

r=me!

Thanks,
Blake.

Comment 6

[Magnus Melin [:mkmelin]]

http://hg.mozilla.org/comm-central/rev/363f59461e36