Closed Bug 748869 Opened 12 years ago Closed 12 years ago

Document l10n enhancements in 1.7

Categories

(Add-on SDK Graveyard :: Documentation, defect, P1)

x86
All
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wbamberg, Assigned: wbamberg)

Details

Attachments

(1 file)

In particular, support for plurals, but also probably worth mentioning the locale updater.
Attached patch a patchSplinter Review
I've added something on plurals and the locale updater.
Attachment #618370 - Flags: review?(poirot.alex)
Comment on attachment 618370 [details] [diff] [review]
a patch

Review of attachment 618370 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks again for you awesome documentation work!
There is just an error about generic localization that is equal to the case called `other`.
Do not hesitate to ping me if you want another round.

::: doc/dev-guide-source/tutorials/l10n.md
@@ +162,5 @@
> +In the `.properties` file for each language you can define a different
> +localization for each plural form possible in that language, using the
> +CLDR keywords. So in English we could have two plural localizations
> +(plus the generic localization, which does not take an accompanying
> +form identifier):

Actually, the generic localization is the `other` case.
So that following example should be:
  tomato_id[one]= tomato
  tomato_id= tomatoes
(The order isn't important)
Note that the following example *do not* works:
  tomato_id[one]= tomato
  tomato_id[other]= tomatoes
I think that's an implementation flow, we should accept both?!

@@ +180,5 @@
> +tomato_id[one]= помидор
> +tomato_id[few]= помидора
> +tomato_id[many]= помидоров
> +tomato_id[other]= помидоры
> +</pre>

Same thing here, generic is equal to `other`.
Attachment #618370 - Flags: review?(poirot.alex) → review+
Priority: -- → P1
Target Milestone: --- → 1.7
ixed by https://github.com/mozilla/addon-sdk/commit/d7d67409383a5869a80755265793183e4d37e653.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a413d7e43e74edce4a7dd2401ad7be035411df64
Bug 748869 - Document l10n enhancements in 1.7; r=@ochameau
(cherry picked from commit d7d67409383a5869a80755265793183e4d37e653)
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d7d67409383a5869a80755265793183e4d37e653
Bug 748869 - Document l10n enhancements in 1.7; r=@ochameau
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: