Last Comment Bug 748937 - Switch JSD destroyScript signature from JSContext -> JSFreeOp
: Switch JSD destroyScript signature from JSContext -> JSFreeOp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Steve Fink [:sfink] [:s:] (PTO Sep23-28)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-25 13:35 PDT by Steve Fink [:sfink] [:s:] (PTO Sep23-28)
Modified: 2012-05-04 09:26 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Switch JSD destroyScript signature from JSContext -> JSFreeOp (4.27 KB, patch)
2012-04-25 13:36 PDT, Steve Fink [:sfink] [:s:] (PTO Sep23-28)
jorendorff: review+
Details | Diff | Splinter Review

Description Steve Fink [:sfink] [:s:] (PTO Sep23-28) 2012-04-25 13:35:57 PDT
This is a warning fix only; JSD doesn't use the argument anyway.
Comment 1 Steve Fink [:sfink] [:s:] (PTO Sep23-28) 2012-04-25 13:36:05 PDT
Created attachment 618414 [details] [diff] [review]
Switch JSD destroyScript signature from JSContext -> JSFreeOp

Sorry, Jason, but you seem to be the automatic reviewer for anything debug-related these days even when it's in JSD.
Comment 2 Jason Orendorff [:jorendorff] 2012-05-03 08:06:57 PDT
Comment on attachment 618414 [details] [diff] [review]
Switch JSD destroyScript signature from JSContext -> JSFreeOp

Thanks.
Comment 3 Steve Fink [:sfink] [:s:] (PTO Sep23-28) 2012-05-03 14:00:31 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/58b4cef7ffcd
Comment 4 Ed Morley [:emorley] 2012-05-04 09:26:42 PDT
https://hg.mozilla.org/mozilla-central/rev/58b4cef7ffcd

Note You need to log in before you can comment on or make changes to this bug.