master import explicitly sets enabled to False, but not same handling on slaves. Might be nice to have cli option to set default, or add as column to csv
Sorry, I was thinking this was done via MySQL import. I can patch this.
Assignee: nobody → dustin
Dustin - thanks, but check with others before changing. I've got a workaround for now, and I've heard rumors of a major slavealloc rework - don't know the details though.
This should be an easy fix. I'll r? the patch obviously :)
Created attachment 655156 [details] [diff] [review] bug748970.patch Generalizes the fix in bug 663018 using a new parameter. I tested this by hand. It occurs to me, when this moves to the new cluster, releng will need somewhere to run the CLI that interacts with the DB. We should set this up on cruncher. I'll get a bug open.
Attachment #655156 - Flags: review?(hwine)
Er, no bug required - MySQL access from cruncher to b01-rw-vip.db.scl3.mozilla.com is already set up, so it should be a simple matter of installing slavealloc in a virtualenv there - a releng task.
Hal, ping for the review?
Comment on attachment 655156 [details] [diff] [review] bug748970.patch Dustin - I'm don't know enough about slavealloc operations to know if this is deployable. The python looks okay, but it needs more slavealloc-experienced-eyes on it for review.
Attachment #655156 - Flags: review?(hwine) → review?
Comment on attachment 655156 [details] [diff] [review] bug748970.patch Heh, thanks! A brief check of the 'hg log' for the source shows bear did most of the reviews, along with a few by nthomas, lsblakk, and one by bhearsum and me. Commits are mostly by me, with one by catlee and one by aki. It sounds like this could use some bus-factor expansion!
Attachment #655156 - Flags: review? → review?(nthomas)
Comment on attachment 655156 [details] [diff] [review] bug748970.patch Seems fine to me too, but I have no recollection of ever reviewing this code. YMMV!
Attachment #655156 - Flags: review?(nthomas) → review+
changeset: 2931:f6959fb120c3 tag: tip user: Dustin J. Mitchell <email@example.com> date: Wed Sep 05 07:46:06 2012 -0400 summary: Bug 748970: allow adding slaves/masters enabled or disabled; r=nthomas I didn't update this on the slavealloc host, though.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
I just patched the slavealloc host because I had to import 800+ pandas in a disabled state :-)
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.