74903 - POP3: Display the error messages sent by the server.

Status: VERIFIED FIXED

(MailNews Core :: Networking: POP, defect, P2)

Description

[Navin Gupta]

Currently we do not display messages sent by the server if a certain command
fails.

Comment 1

[Navin Gupta]

Attachment: proposed fix.

Comment 2

[Navin Gupta]

This patch displays the error message sent by the server in response to a
particular command. Previously we were just displaying a general message 
"An error has occured....".

cc mscott and sspitzer for r/sr

Comment 3

[Scott MacGregor]

Couple comments:
1) you should probably use nsXPIDLStrings for serverSaidPrefix, serverResponse, 
and alertString. that way you won't have to spend time worrying about freeing
the memory. 

2) is m_commandResponse a char * (nsCString)? is that why we have to call get
new unicode on it instead of just using it? You could probably get rid of
serverResponse variable and just call .AppendWithConversion(m_commandResponse.get())

3)  message.AppendWithConversion(' '); could be written as:
message.Append(NS_LITERAL_STRING(' ').get()); . this is going to have one less
memory allocation on some platforms. 

everything else looks good.

Comment 4

[Navin Gupta]

Attachment: [e-mail]

Comment 5

[Navin Gupta]

revised patch. 

Comment 6

[Navin Gupta]

fix checked in.

Comment 7

[Sheela Ravindran]

navin,
what error messages? what are the commands.
need more information to verify this bug. thanks

Comment 8

[Navin Gupta]

If you see carefully some of messages in the error dialogs have changed and 
they always have " The mail server responded : ......". One common one is 
when you enter wrong password. 

Comment 9

[Sheela Ravindran]

Buildid: 2001042606 win98, mac, linux
verified few error messages based on navin's attachment on 2001-04-05 18:43