Closed
Bug 749051
Opened 12 years ago
Closed 12 years ago
TryChooser: could -n be the default?
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: luke, Assigned: lsblakk)
Details
(Whiteboard: [tryserver])
Attachments
(2 files, 4 obsolete files)
1.49 KB,
patch
|
catlee
:
review+
lsblakk
:
checked-in+
|
Details | Diff | Splinter Review |
2.67 KB,
patch
|
lsblakk
:
checked-in+
|
Details | Diff | Splinter Review |
If tinderbox servers spend a significant amount of cpu time shooting out emails, perhaps we could make -n the default. Most of us get all our try results through tbpl anyhow and I suspect many recipients of try emails just don't know about -n or (like I often do) forget to add it until right after they push.
Updated•12 years ago
|
Component: Release Engineering → Release Engineering: Developer Tools
QA Contact: release → lsblakk
Reporter | ||
Comment 1•12 years ago
|
||
It's spreading! http://30.media.tumblr.com/tumblr_m3drm62Me11rrf1eeo1_1280.jpg
Assignee | ||
Comment 2•12 years ago
|
||
this will make no emails the default, no flagging needed, and to get failure emails, a person can request -f
Assignee: nobody → lsblakk
Attachment #620761 -
Flags: review?(catlee)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #620763 -
Flags: review?(catlee)
Assignee | ||
Comment 4•12 years ago
|
||
the correct patch this time.
Attachment #620763 -
Attachment is obsolete: true
Attachment #620763 -
Flags: review?(catlee)
Attachment #620764 -
Flags: review?(catlee)
Assignee | ||
Comment 5•12 years ago
|
||
no. really. the right patch now.
Attachment #620764 -
Attachment is obsolete: true
Attachment #620764 -
Flags: review?(catlee)
Attachment #620765 -
Flags: review?(catlee)
Assignee | ||
Comment 6•12 years ago
|
||
you can't even handle the level of pebkac here.
Attachment #620765 -
Attachment is obsolete: true
Attachment #620765 -
Flags: review?(catlee)
Attachment #620766 -
Flags: review?(catlee)
Updated•12 years ago
|
Attachment #620766 -
Flags: review?(catlee) → review+
Updated•12 years ago
|
Attachment #620761 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 620766 [details] [diff] [review] corresponding trychooser webpage update to reflect new norm http://hg.mozilla.org/build/tools/rev/8b10fbdcccd3 landed, but will wait to deploy until our next reconfig when this goes live.
Attachment #620766 -
Flags: checked-in+
Assignee | ||
Comment 8•12 years ago
|
||
Comment on attachment 620761 [details] [diff] [review] change try email flags to -f failure emails, make email silence the default http://hg.mozilla.org/build/buildbotcustom/rev/523a9a4717a3 landed on default, will go out in the next reconfig.
Attachment #620761 -
Flags: checked-in+
Reporter | ||
Comment 9•12 years ago
|
||
Thanks!
Comment 10•12 years ago
|
||
made it to production today
Comment 11•12 years ago
|
||
Had to back this out because it broke try_mailer.py: Running [u'/builds/buildbot/tests1-tegra/bin/python', u'/builds/buildbot/tests1-tegra/lib/python2.6/site-packages/buildbotcustom/bin/try_mailer.py', u'--log-url', u'http://ftp.mozilla.org/pub/mozilla.org/mobile/try-builds/jwalker@mozilla.com-75fd0429c01e/try-android/try_tegra_android_test-jsreftest-3-bm20-tests1-tegra-build2079.txt.gz', u'-f', u'tryserver@build.mozilla.org', u'--to-author', u'/builds/buildbot/tests1-tegra/master/try_tegra_android_test-jsreftest-3', u'2079'] File "/builds/buildbot/tests1-tegra/lib/python2.6/site-packages/buildbotcustom/bin/try_mailer.py", line 196 if tm_options.all_emails:
Assignee | ||
Comment 12•12 years ago
|
||
new patch with indentation bustage fixed, landed: http://hg.mozilla.org/build/buildbotcustom/rev/34aa7e9d73ae
Attachment #620761 -
Attachment is obsolete: true
Attachment #622382 -
Flags: checked-in+
Comment 13•12 years ago
|
||
You got redeployed sometime last week, so deploying the trychooser change would be a good thing, since people who actually do want -f now have to... guess that it might be -f, I suppose.
Assignee | ||
Comment 14•12 years ago
|
||
done, thanks for the reminder.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•7 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•