Closed
Bug 749056
Opened 14 years ago
Closed 14 years ago
Updating to Latest Version of Talos failing on Windows
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fahim.zahur, Assigned: kats)
References
Details
Attachments
(1 file)
|
3.17 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.162 Safari/535.19
Steps to reproduce:
I was trying to update Talos to the latest revision
Actual results:
I got the following error:
% hg update --repository C:\Users\fzahur\Talos --config ui.merge=internal:merge --rev 442 --check
abort: filename contains '?', which is reserved on Windows: 'talos/startup_test/fennecmark/cnn/ad.insightexpressai.com/adserver/adServer.aspx?publisherID=97.html'
[command returned code 255 Wed Apr 25 21:31:26 2012]
Talos%
Comment 1•14 years ago
|
||
Windows has some restrictions on file names and is also case INSENSITIVE so when making changes, these should be considered. Adding William since I think he was the one who added CNN test page for fennec.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•14 years ago
|
||
Gross. We can probably fix this by renaming the 'adServer.aspx?publisherID=97.html' file (and updating the reference to it).
(it actually wasn't me who added the file, it was kats who I just CCed)
Comment 3•14 years ago
|
||
(In reply to William Lachance (:wlach) from comment #2)
> Gross. We can probably fix this by renaming the
> 'adServer.aspx?publisherID=97.html' file (and updating the reference to it).
I think this is the way to go too.
| Assignee | ||
Comment 4•14 years ago
|
||
Oh, didn't realize that would be a problem, sorry. Do you waant me tomake the change? It should be fairly straightforward.
| Assignee | ||
Comment 5•14 years ago
|
||
(Sorry for typos, crappy mobile keyboard)
| Assignee | ||
Comment 6•14 years ago
|
||
Assignee: nobody → bugmail.mozilla
Attachment #618674 -
Flags: review?(jmaher)
Comment 7•14 years ago
|
||
Comment on attachment 618674 [details] [diff] [review]
Remove question mark characters from filenames
Review of attachment 618674 [details] [diff] [review]:
-----------------------------------------------------------------
this removes the reference to it, but the hg pull is failing. We need to fix the 4 files that have ? in the name.
Attachment #618674 -
Flags: review?(jmaher) → review-
| Assignee | ||
Comment 8•14 years ago
|
||
The patch renames the files as well. splinter won't show it though.
Comment 9•14 years ago
|
||
Comment on attachment 618674 [details] [diff] [review]
Remove question mark characters from filenames
Review of attachment 618674 [details] [diff] [review]:
-----------------------------------------------------------------
oh, I changed my mind. The patch really does have renames for the files and those remaining characters seem valid in the windows filesystem.
Attachment #618674 -
Flags: review- → review+
| Assignee | ||
Comment 10•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•