749079 - [traceback] AttributeError: 'Settings' object has no attribute 'BANNERS_HASH'

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://affiliates-dev.allizom.org/link/banner/107 throws this traceback:

Traceback (most recent call last):

  File "/data/www/affiliates-dev.allizom.org/affiliates-app/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/affiliates-dev.allizom.org/affiliates-app/vendor/src/django/django/views/decorators/cache.py", line 79, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)

  File "/data/www/affiliates-dev.allizom.org/affiliates-app/apps/banners/views.py", line 67, in link
    if filename in settings.BANNERS_HASH:

  File "/data/www/affiliates-dev.allizom.org/affiliates-app/vendor/src/django/django/utils/functional.py", line 277, in __getattr__
    return getattr(self._wrapped, name)

AttributeError: 'Settings' object has no attribute 'BANNERS_HASH'

Comment 1

[Matt Brandt [:mbrandt]]

There are still quite a few of these tracebacks being sent by dev. Should we be concerned?

'HTTP_FROM': 'googlebot(at)googlebot.com',
'REQUEST_URI': '/link/banner/107'

Comment 2

[Anthony Ricaud (:rik)]

This error was caused by BANNERS_HASH being set in the local settings. And we forgot to update dev with this setting. But since, BANNERS_HASH is in the base settings.


I have no traceback with this error after June 9.

Comment 3

[Matt Brandt [:mbrandt]]

I'm happy to bump this to QA verified - I haven't seen tracebacks since dev's settings were updated.