749107 - Video frames are tiled all over the viewport for Flash and HTML5 webm videos

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Adrian Tamas (:AdrianT)]

Fennec/15.0a1 2012-04-25
Device: HTC Desire (Android 2.2)/HTC Desire Z (Android 2.3)
Flash version: 11.1.111.8

Steps to reproduce:
1. Set plugin preferences to enable and restart Firefox Mobile for the changes to take effect.
2. Load http://youtu.be/sftuxbvGwiU - this was the only video I found until now that behaves this way.
3. Start the video.
4. After the video starts scroll the page.

Expected results:
Video plays without any issues.

Actual results:
Frames of the video are tiled all over the viewport covering everything including new opened tabs. Please see the video: http://youtu.be/8LcfmDszORs.

On Samsung Galaxy S2 (Android 2.3) and Samsung Captivate (Android 2.2) the issue is only seen while scrolling

Comment 1

[Adrian Tamas (:AdrianT)]

Attachment: logs

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Also tiling-related.

Comment 3

[Joe Drew (not getting mail)]

For ease of linking: http://www.youtube.com/watch?feature=player_detailpage&v=8LcfmDszORs#t=42s

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

qawanted to try to repro on https://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-aurora-android/1335458320/fennec-14.0a2.en-US.android-arm.apk

Comment 5

[Adrian Tamas (:AdrianT)]

After rechecking this I have noticed that the original youtube link was wrong. Sorry about that. 
This is the correct link:
http://www.youtube.com/watch?v=JXXD34mxGM0

Comment 6

[Adrian Tamas (:AdrianT)]

Attachment: HTC Desire log on Fennec 14 tinderbox build

Using the correct link I am able to reproduce the initial issue on HTC Desire and HTC Desire Z on the tinderbox Fennec/14.0a2 build. Attaching logs.

Comment 7

[Adrian Tamas (:AdrianT)]

After further investigations I can also the reproduce the issue using a second video: http://youtu.be/umU6cenjctI. Both videos actually seem to be HTML5 not Flash which would explain why the issue is not reproducible on all youtube videos. 
Checking html5 videos outside of youtube I can also reproduce the issue at http://people.mozilla.com/~nhirata/html_tp/big_buck_bunny_480p.webm and http://people.mozilla.com/~nhirata/html_tp/elephants-dream.webm.

Comment 8

[Adrian Tamas (:AdrianT)]

Attachment: logs Samsung Captivate Fennec 14 build

Issue can be seen on the Samsung Captivate only when the page is scrolled.

Comment 9

[Catalin Suciu [:csuciu]]

Reproducible on Samsung Galaxy SII (Android 2.3.4) using https://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-aurora-android/1335458320/fennec-14.0a2.en-US.android-arm.apk

Just load http://www.youtube.com/watch?v=JXXD34mxGM0 and while playing the video, scroll the page

Comment 10

[Catalin Suciu [:csuciu]]

Attachment: Logs Samsung Galaxy SII

Comment 11

[JP Rosevear [:jpr]]

Moving to Benoit since its very likely to be tiling.

Comment 12

[Adrian Tamas (:AdrianT)]

Attachment: logs Samsung Galaxy Nexus

Issue is also reproducible only when scrolling the page on Samsung Galaxy Nexus running Android 4.0.2

Comment 13

[Martijn Wargers (dead)]

I can rerproduce with the webm videos of comment 7, using the Samsung Galaxy Nexus.
I think this is a regression.
Let me know if you need a regression range.

Comment 14

[Tony Chung [:tchung]]

not just webm, flash also.

i used the link from comment 5, which seems to be a flash file.   for me, it tiles only when i tap or pan the screen.   

Galaxy Nexus, 4.0.2, aurora tinderbox build:  https://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-aurora-android/1335478518/fennec-14.0a2.en-US.android-arm.apk

Comment 15

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 16

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 619624 [details] [diff] [review]
patch

Review of attachment 619624 [details] [diff] [review]:
-----------------------------------------------------------------

Choose a good commit message

Comment 17

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22a3eddd0c5b

Comment 18

[Benoit Girard (:BenWa)]

I couldn't reproduce the bug without this patch (only tried one link). If someone has a chance to try with/without this changeset that would be lovely.

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=22a3eddd0c5b

Comment 19

[Benoit Girard (:BenWa)]

Comment on attachment 619624 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): Bug 739679 - Add a Shadowable TiledThebesLayer implementation
User impact if declined: Tiles may show wrong texture when other elements are drawn (video/plugins).
Testing completed (on m-c, etc.): Will wait for bake time and QA feedback before uplift.
Risk to taking this patch (and alternatives if risky): Small, we were not managing the texture unit state properly. This patch fixes that.
String changes made by this patch: none

Comment 20

[Tony Chung [:tchung]]

Verified fixed on brad's aurora try build.  

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-c3deb5626819

Comment 21

[JP Rosevear [:jpr]]

Comment on attachment 619624 [details] [diff] [review]
patch

Please land, turns out not to depend on snorp's work, I was mixing up bugs.

Comment 22

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/570951bd8b38

Comment 23

[Tony Chung [:tchung]]

Nexus S, Android 2.3.

Verified fix on tinderbox aurora, using testcase from comment 5.  no tiling.

ftp://ftp.mozilla.org/pub/mobile/tinderbox-builds/mozilla-aurora-android/1335995418/

Comment 24

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/22a3eddd0c5b

Comment 25

[Adrian Tamas (:AdrianT)]

Verified on:
Nightly 15.0a1 2012-05-03 / Aurora 14.0a2 2012-05-03
Device: HTC Desire
OS: Android 2.2

Comment 26

[Martijn Wargers (dead)]

I'm still seeing video artifacts in the canvas background, while playing videos, I filed bug 751564 for it.