Closed Bug 74912 Opened 23 years ago Closed 6 years ago

nsHTMLEditor::InsertCitedQuotation should use fast docFrag insertion when available

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

RESOLVED INVALID
mozilla1.4beta

People

(Reporter: mozeditor, Unassigned)

References

(Depends on 1 open bug)

Details

(Keywords: perf, Whiteboard: [perf] fix in hand, patch in 35295)

Once 74907 is fixed, make sure editor makes use of that work to increase mail 
reply performance.
Blocks: 22486
setting this to moz0.9.1, and setting depends on 74907
Depends on: 74907
Priority: -- → P2
Target Milestone: --- → mozilla0.9.1
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Joe, why is this moving out of our release?  jst has said he'll be doing his
part next week and we need the whole solution to see any benefit...
Steve, I had 70+ 091 bugs which I mass moved to appease the bug gods.  The 
milestone is meaningless at this moment.  I'll pull bugs back as needed.  
Priority of this effort has not changed.  

If my ws work lands in time, johnny is ready in time, then there is no reason 
this won't happen for 091.
Updating dependency since 74907 was dup of 35294.
Depends on: 35294
No longer depends on: 74907
I put patches to do exactly this in bug 39295.  They aren't ready to be checked 
in but they should be fine for allowing testing of layout performance 
improvements to docFrag insertion.
Status: NEW → ASSIGNED
moving to 1.0
Keywords: perf
Whiteboard: [perf]
Target Milestone: mozilla0.9.2 → mozilla1.0
Beth, are you really pushing this out of the release?  Joe's prior comments
indicated this would happen when ready, not that it wasn't going to happen at
all.  What can we do to help keep this in the release?
awaiting review/approval
Whiteboard: [perf] → [perf] fix in hand, patch in 35295
What's up with this bug?  jfrancis: this is awaiting review/approval, but
there's no patch attached, and the bug you mention as having a patch in it
doesn't seem to have anything to do with this one (typo on bug number?)  Is this
still waiting on 35294?  (See comments there too.)
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
removing myself from the cc list
we have bug 35295, bug 35294 and bug 39295
which one is this *really* waiting for? (My bet is on 35295 ;-)
It was 35295, lLost in the mists of time.  I went through a big drill on this and 
in the end we didn't land it because of some impacts in clicking on blank lines 
of mailquotes.

However, it is possible that we could still make improvements here by using 
docfrags.  Instead of just hucking the quoted message in unmolested as a docfrag, 
we could try a hybrid approach: still do the newline->br conversion for plaintext 
quotes, but do it inside a docfrag rather than after the insertion into the 
document.  

How high a priority is this?  Do mail folks have new stats on mail compose 
startup performance that indicate this is high priority?
The days of having a half dozen milestones out in front of us to divide bugs 
between seem to be gone, though I dont know why.  Lumping everything together as 
far out as I can.  I'll pull back things that I am working on as I go.
Target Milestone: mozilla1.0.1 → mozilla1.2beta
[ushing these out as far as bugzilla will let me.  I'll pull them back as I work
on them.
Target Milestone: mozilla1.2beta → mozilla1.4beta
QA Contact: sujay → editor
Assignee: mozeditor → nobody
Status: ASSIGNED → NEW
Depends on: 35295
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3
old bug, so if this bug is necessary, we should file a new bug since this is mail issue
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.