toolkit/devtools/debugger/Makefile.in should install debugger JSMs as symlinks for development

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimb, Unassigned)

Tracking

Trunk
Firefox 15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 618663 [details] [diff] [review]
Install the debug server jsms as symlinks, when appropriate.

At the moment, the debugger Makefile.in copies the JSMs in toolkit/devtools/debugger and toolkit/devtools/debugger/server into dist/bin/modules/devtools. It should symlink them in, to make development easier.
Attachment #618663 - Flags: review?(rcampbell)
(Reporter)

Comment 1

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=a862405cfb7b
(Reporter)

Comment 2

5 years ago
Note that the "ac_add_options --enable-chrome-format=symlink" doesn't provide this functionality. I'm not sure why, but those JSMs aren't installed in the same way as the .js files.
Comment on attachment 618663 [details] [diff] [review]
Install the debug server jsms as symlinks, when appropriate.

ok!
Attachment #618663 - Flags: review?(rcampbell) → review+
(Reporter)

Comment 4

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/41e7d93533c1
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/41e7d93533c1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
(Reporter)

Comment 6

5 years ago
Talos sent me email claiming that I'd regressed performance. I wept for several days, but then gathered my wits about me and looked at this chart:

http://graphs-new.mozilla.org/graph.html#tests=[[196,64,21]]&sel=none&displayrange=30&datatype=running

and decided that my commit, on May 1st, was not responsible for the regression.
there there, jim. Talos can't hurt you anymore.
You need to log in before you can comment on or make changes to this bug.