Last Comment Bug 749215 - toolkit/devtools/debugger/Makefile.in should install debugger JSMs as symlinks for development
: toolkit/devtools/debugger/Makefile.in should install debugger JSMs as symlink...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Debugger (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 15
Assigned To: Nobody; OK to take it and work on it
:
: James Long (:jlongster)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-26 08:35 PDT by Jim Blandy :jimb
Modified: 2012-05-07 07:41 PDT (History)
3 users (show)
jimb: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Install the debug server jsms as symlinks, when appropriate. (602 bytes, patch)
2012-04-26 08:35 PDT, Jim Blandy :jimb
rcampbell: review+
Details | Diff | Splinter Review

Description Jim Blandy :jimb 2012-04-26 08:35:03 PDT
Created attachment 618663 [details] [diff] [review]
Install the debug server jsms as symlinks, when appropriate.

At the moment, the debugger Makefile.in copies the JSMs in toolkit/devtools/debugger and toolkit/devtools/debugger/server into dist/bin/modules/devtools. It should symlink them in, to make development easier.
Comment 1 Jim Blandy :jimb 2012-04-26 08:53:33 PDT
https://tbpl.mozilla.org/?tree=Try&rev=a862405cfb7b
Comment 2 Jim Blandy :jimb 2012-04-26 08:55:02 PDT
Note that the "ac_add_options --enable-chrome-format=symlink" doesn't provide this functionality. I'm not sure why, but those JSMs aren't installed in the same way as the .js files.
Comment 3 Rob Campbell [:rc] (:robcee) 2012-04-27 08:11:36 PDT
Comment on attachment 618663 [details] [diff] [review]
Install the debug server jsms as symlinks, when appropriate.

ok!
Comment 5 Tim Taubert [:ttaubert] 2012-05-02 06:48:17 PDT
https://hg.mozilla.org/mozilla-central/rev/41e7d93533c1
Comment 6 Jim Blandy :jimb 2012-05-04 11:04:25 PDT
Talos sent me email claiming that I'd regressed performance. I wept for several days, but then gathered my wits about me and looked at this chart:

http://graphs-new.mozilla.org/graph.html#tests=[[196,64,21]]&sel=none&displayrange=30&datatype=running

and decided that my commit, on May 1st, was not responsible for the regression.
Comment 7 Rob Campbell [:rc] (:robcee) 2012-05-07 07:41:25 PDT
there there, jim. Talos can't hurt you anymore.

Note You need to log in before you can comment on or make changes to this bug.