749225 - Stack trace: Incorrect line numbers for jsms that include preprocessor directives

Status: RESOLVED DUPLICATE of bug 797322

(Firefox Build System :: General, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

When a jsm contains preprocessor directives it knocks the line numbers out of sync for stack traces. I guess this may also cause issues with choosing the correct line from the debugger.

e.g.
    if (modifiersAttr.match("accel"))
#ifdef XP_MACOSX
      combo.push(keysbundle.GetStringFromName("VK_META"));
#else
      combo.push(keysbundle.GetStringFromName("VK_CONTROL"));
#endif
    if (modifiersAttr.match("shift"))
      combo.push(keysbundle.GetStringFromName("VK_SHIFT"));

will offset the line by 4.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Is this something that should be fixed in the JS engine, or something that should be fixed in the preprocessor? IMO this bug should be moved to Core::Build Config and config/Preprocessor.py should be modified to insert blank lines whenever it takes things out so that line numbers are preserved.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Agreed.

Comment 4

[Mike Hommey [:glandium]]

See also bug 797325 as to why even when Preprocess is helpful, the stacktraces still aren't.