749228 - From autocomplete popups reopens after tapping on autocomplete entry

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

I suspect this is a regression from bug 736008, I don't see this bug occuring in Aurora, at least (yet).

Steps to reproduce:
- Go to testcase
- Type 'a', then submit
- Type 'ab', then submit
- Type 'abc', then submit
- Tap on the text input to open the form autocomplete popup
- Tap on the 'a' entry in there


Expected result:
- 'a' appears in the text input, form autocomplete popup disappears

Actual result:
- 'a' appears in the text input, form autocomplete popup reopens with remaining suggestions

Comment 1

[:Margaret Leibovic]

This sounds more like it would be caused by bug 735747, but that's in aurora. Maybe it's some bad interaction between that bug and bug 736008.

Comment 2

[Martijn Wargers (dead)]

Yeah,  I guess you're right, I saw this bug too in a trunk build before bug 736008 was fixed.

Comment 3

[Ioana Chiorean]

As a regression window : 
Good build:17.04.2012
Bad build:18.04.2012

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c61e7c3a232a&tochange=0c7e2911be75

Comment 4

[Aaron Train [:aaronmt]]

Right, bug 735747.

Comment 5

[Martijn Wargers (dead)]

In Firefox desktop, there is a mSuppressOnInput that is set to false to prevent the autocomplete from appearing oninut, in nsFormFillController.cpp.
So I guess this needs something similar.

Something like this?
+  this._suppresinput = true;
editableElement.setUserInput(aData);
+  this._suppresinput = false;

And then in http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#4638
+ if (this._suppresinput)
+  break;

Comment 6

[Martijn Wargers (dead)]

Attachment: patch

Something like this.
I tried my own build, but somehow that build seems hosed. Or isn't it possible to build on MacOS X platorm, realibly?

Comment 7

[Martijn Wargers (dead)]

Ok, I made a tryserver build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-330435a06c28

Comment 8

[Martijn Wargers (dead)]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #6)
> I tried my own build, but somehow that build seems hosed. Or isn't it
> possible to build on MacOS X platorm, realibly?

Ugh, this happened because the patch is not good.

Comment 9

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.