Merge recent peptest changes into m-c

RESOLVED FIXED in mozilla15

Status

Testing
Peptest
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mcote, Assigned: mcote)

Tracking

Trunk
mozilla15
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

6 years ago
Depends on: 749277
(Assignee)

Comment 1

6 years ago
Created attachment 620173 [details] [diff] [review]
configurable number of iterations; misc. fixes

This patch contains everything you reviewed in the github peptest repo plus one more changeset (https://github.com/mozilla/peptest/commit/2f04593e61b7784ff0e1d68b4075869070c4ae68). This last changeset does a few things:

- changes from iterating over each test to iterating over the whole testsuite. I found the numbers to be much more consistent this way.
- a few fixes to tests, notably closing context menus that were previously left open (which interfered with other tests), and removing the add-on-bar toggling, since it didn't seem to do anything (I guess no appropriate add-ons installed).
- catch exceptions in performAction() so that we clean up properly.
- remove the failure threshold for open bookmarks. Since this is now a performance framework and not pass/fail, there's no point in hiding unresponsiveness below a certain level.

I did *not* add a --iterations option to the makefile. Devs can rerun it via 'make peptest' as much as they want. Mozharness will handle the number of iterations for the automated runs.

Please push this to either m-i or m-c after reviewing. :) I will then ask aki to do the appropriate mozharness-config modifications.
Attachment #620173 - Flags: review?(ctalbert)

Updated

6 years ago
Attachment #620173 - Flags: review?(ctalbert) → review+

Comment 2

6 years ago
Landed:https://hg.mozilla.org/integration/mozilla-inbound/rev/a2647e37b065
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/a2647e37b065

(Normally left open until the bug merges to mozilla-central :-))
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.