749361 - reduce MAX_LEAK_COUNT to match the status quo

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

All InstallTrigger test leaks are gone.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 618792 [details] [diff] [review]
patch

Review of attachment 618792 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, that's a pretty awesome reduction.

Comment 2

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/3e1e3e341477

Comment 3

[Serge Gautherie (:sgautherie)]

SeaMonkey, wrt bug 695480:
*previous: 34 DW + 4 DS
*current : 40 DW + 4 DS (due to regression noted in bug 749532)

Please, use 44 ftb (not 23).

Comment 4

[Dão Gottwald [:dao]]

(In reply to Serge Gautherie (:sgautherie) from comment #3)
> Please, use 44 ftb (not 23).

We can't do that. We wouldn't catch any regressions until we reached 44.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to Dão Gottwald [:dao] from comment #4)
> We can't do that. We wouldn't catch any regressions until we reached 44.

Then what is the plan to support other applications like SeaMonkey?

Comment 6

[Dão Gottwald [:dao]]

(In reply to Serge Gautherie (:sgautherie) from comment #5)
> (In reply to Dão Gottwald [:dao] from comment #4)
> > We can't do that. We wouldn't catch any regressions until we reached 44.
> 
> Then what is the plan to support other applications like SeaMonkey?

It sounds like it needs a separate threshold or the check should be limited to Firefox altogether.

Comment 7

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] from comment #6)
> (In reply to Serge Gautherie (:sgautherie) from comment #5)
> > (In reply to Dão Gottwald [:dao] from comment #4)
> > > We can't do that. We wouldn't catch any regressions until we reached 44.
> > 
> > Then what is the plan to support other applications like SeaMonkey?
> 
> It sounds like it needs a separate threshold or the check should be limited
> to Firefox altogether.

Or you disable some leaking tests, which would be the simplest short-term solution.