749431 - Build gtest

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Comment 1

[Eric Rescorla (:ekr)]

Attachment: Build gtest

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 618835 [details] [diff] [review]
Build gtest

Review of attachment 618835 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nit fixed

::: media/webrtc/Makefile.in
@@ +43,5 @@
>  
>  include $(DEPTH)/config/autoconf.mk
>  
> +DIRS := trunk \
> +	trunk/testing

Please change to standard Mozilla Makefile.in idiom for multi-line lists of:
BLAH = \
       foo \
       bar \
       $(NULL)

Note also = instead of :=; there are no other DIRS := in the tree (though it really doesn't matter)

Comment 3

[Ethan Hugg [:ehugg]]

Attachment: build gtest - should now work on Linux f=ekr

Comment 4

[Ethan Hugg [:ehugg]]

Comment on attachment 621839 [details] [diff] [review]
build gtest - should now work on Linux f=ekr

Had to change the syntax of the DIRS = line to get it to build on Linux.

Comment 5

[Eric Rescorla (:ekr)]

This looks awful similar to what I actually committed in: ff154c883abafc8ff619d32aa9e2faa474a5bdb6

Can you confirm that that does not work?

Comment 6

[Ethan Hugg [:ehugg]]

It's the same.  I was off fixing it myself when I should've been paying more attention to the checkins.