Closed Bug 749431 Opened 9 years ago Closed 9 years ago

Build gtest

Categories

(Core :: WebRTC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ekr, Assigned: ekr)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch Build gtestSplinter Review
Attachment #618835 - Flags: review?(rjesup)
Comment on attachment 618835 [details] [diff] [review]
Build gtest

Review of attachment 618835 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nit fixed

::: media/webrtc/Makefile.in
@@ +43,5 @@
>  
>  include $(DEPTH)/config/autoconf.mk
>  
> +DIRS := trunk \
> +	trunk/testing

Please change to standard Mozilla Makefile.in idiom for multi-line lists of:
BLAH = \
       foo \
       bar \
       $(NULL)

Note also = instead of :=; there are no other DIRS := in the tree (though it really doesn't matter)
Attachment #618835 - Flags: review?(rjesup) → review+
Comment on attachment 621839 [details] [diff] [review]
build gtest - should now work on Linux f=ekr

Had to change the syntax of the DIRS = line to get it to build on Linux.
Attachment #621839 - Flags: feedback?(ekr)
This looks awful similar to what I actually committed in: ff154c883abafc8ff619d32aa9e2faa474a5bdb6

Can you confirm that that does not work?
Attachment #621839 - Flags: feedback?(ekr)
It's the same.  I was off fixing it myself when I should've been paying more attention to the checkins.
Attachment #621839 - Attachment is obsolete: true
QA Contact: jsmith
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.