749438 - fix color conversion in ScreenshotLayer.updateBackground

Status: RESOLVED DUPLICATE of bug 749630

(Firefox for Android Graveyard :: General, defect)

Description

[microrffr]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/gfx/ScreenshotLayer.java#179

shifting happening before bitwise and

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

microrffr... it seems like your report got chopped before you finished it.  Can you repeat what the issue is please?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

This was fixed with bug 749630.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

For the record, the problem microrffr was pointing out was that this code:

-        int red =   ((color & 0x00FF0000 >> 16)* 31 / 255);
-        int green = ((color & 0x0000FF00 >> 8) * 63 / 255);
-        int blue =   (color & 0x000000FF) * 31 / 255;

does a bitwise-and and a bitshift without indicating precedence by using parentheses. "color & 0x00FF0000 >> 16" evaluates the >> first, resulting in "color & 0x000000FF" instead of "(color & 0x00FF0000) >> 16" as intended.

This code was removed by :Cwiiis as part of the bug mentioned above.

Comment 4

[microrffr]

oops my bad

:kats's description is accurate.